fix: use message=None instead of message="" in job_orchestrator#935
fix: use message=None instead of message="" in job_orchestrator#935sophiecuiy merged 1 commit intomainfrom
Conversation
With the `is not None` checks in `AirbyteTracedException.__str__` (PR #927), `message=""` returns an empty string instead of falling back to the detailed `internal_message`. Using `None` lets the fallback work correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@sophie/fix-job-orchestrator-empty-message#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch sophie/fix-job-orchestrator-empty-messagePR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Pull request overview
Updates AirbyteTracedException construction in the async job orchestrator to ensure str(exc) preserves diagnostic context after the AirbyteTracedException.__str__ behavior change introduced in PR #927.
Changes:
- Replace
message=""withmessage=Nonewhen raisingAirbyteTracedExceptionso__str__falls back tointernal_message.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 WalkthroughWalkthroughA single-line change in the job orchestrator that modifies the exception payload when raising a final aggregated error. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
message=""tomessage=Noneinjob_orchestrator.py:484so thatstr(exc)falls back to the detailedinternal_messageinstead of returning an empty string.This is a companion fix for PR #927, which adds
is not Nonechecks inAirbyteTracedException.__str__. With those checks,message=""would return""instead of falling back tointernal_message, silently losing all diagnostic context.Test plan
as_airbyte_message()output since it readsmessageandinternal_messagefields directly.str(exc)now correctly returns the joinedinternal_messageinstead of an empty string.🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.