fix(cdk): Improve HTTP 400 error message (AI-Triage PR)#943
Closed
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Closed
fix(cdk): Improve HTTP 400 error message (AI-Triage PR)#943devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Remove vague remediation language ('Please check your request parameters')
and redundant HTTP status code prefix from the default 400 error message.
New message follows error message guidelines:
- No remediation/please language
- Concise and specific
- Under 120 characters
- Deterministic
Related to airbytehq/airbyte-internal-issues#15970
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1773119005-improve-400-error-message#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1773119005-improve-400-error-messagePR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
PyTest Results (Fast)3 892 tests ±0 3 880 ✅ ±0 6m 52s ⏱️ +6s Results for commit 477787d. ± Comparison against base commit f550424. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
PyTest Results (Full)3 895 tests ±0 3 883 ✅ ±0 11m 33s ⏱️ +19s Results for commit 477787d. ± Comparison against base commit f550424. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cdk): Improve HTTP 400 error message (AI-Triage PR)
Summary
Improves the default HTTP 400 error message in
DEFAULT_ERROR_MAPPINGto comply with Airbyte's error message guidelines.Before:
"HTTP Status Code: 400. Error: Bad request. Please check your request parameters."After:
"Bad request response from source API."The old message violated several guidelines:
The new message is concise, deterministic, and follows the
<Subject> <violated_condition> [qualifier].format.This change affects all HTTP-based source connectors that rely on the CDK's default error mapping for 400 responses. Connectors with custom error handlers are unaffected.
Related to https://github.com/airbytehq/airbyte-internal-issues/issues/15970
Review & Testing Checklist for Human
airbytehq/airbyteor other repos assert on the exact old string"HTTP Status Code: 400. Error: Bad request. Please check your request parameters.". A grep across the monorepo is recommended."Bad request response from source API."is clear and appropriate as a generic default for all source connectors encountering HTTP 400.system_errortype is preserved. Consider whether this is the best default for 400 responses (which can indicate either a connector bug or a user config issue depending on context).Notes
FailureTypeandResponseActionare intentionally left unchanged to keep this PR minimal and low-risk.Requested by: bot_apk
Devin session