Skip to content

fix(oauth): improve refresh-token error message; remove 'please' and dead placeholder #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(oauth): improve refresh-token error message; remove 'please' and dead placeholder #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions airbyte_cdk/sources/streams/http/requests_native_auth/abstract_oauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,9 +305,15 @@ def _make_handled_request(self) -> Any:
failure_type=FailureType.transient_error,
)
if self._wrap_refresh_token_exception(e):
message = "Refresh token is invalid or expired. Please re-authenticate from Sources/<your source>/Settings."
status_code = e.response.status_code if e.response is not None else "unknown"
raise AirbyteTracedException(
internal_message=message, message=message, failure_type=FailureType.config_error
message="OAuth token refresh failed with a refresh-token error response.",
internal_message=(
f"OAuth token refresh failed with HTTP {status_code}; "
"response matched configured refresh-token error indicators "
"(see DEBUG-level token refresh log for full response)."
),
failure_type=FailureType.config_error,
)
raise
except Exception as e:
Expand Down
8 changes: 5 additions & 3 deletions unit_tests/sources/streams/http/requests_native_auth/test_requests_native_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,9 +575,11 @@ def test_refresh_access_token_wrapped(
oauth.refresh_access_token()

if wrapped:
error_message = "Refresh token is invalid or expired. Please re-authenticate from Sources/<your source>/Settings."
assert exc_info.value.internal_message == error_message
assert exc_info.value.message == error_message
expected_message = "OAuth token refresh failed with a refresh-token error response."
assert exc_info.value.message == expected_message
assert exc_info.value.internal_message.startswith(
f"OAuth token refresh failed with HTTP {response_code}"
)
assert exc_info.value.failure_type == FailureType.config_error


Expand Down
Loading