fix: resolve MyPy type check failures#1045
Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
Draft
fix: resolve MyPy type check failures#1045Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
Conversation
Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1780716827-repro-mypy-ci-failures#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1780716827-repro-mypy-ci-failuresPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Co-Authored-By: AJ Steers <aj@airbyte.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nFixes 10 MyPy type check errors that fail in CI but not locally (likely due to CI using Python 3.10 + Poetry 1.8.4 with different dependency resolution):\n\n-
checkpoint_reader.py:self.current_slicetyped asStreamSlice | None— use localcurrentvariable after_find_next_slice()to avoid repeated property access throughOptionaltype\n-utils.py/connector_builder_handler.py:Mapping.get()returnsAny— wrap withbool()to satisfy-> boolreturn type\n-default_file_based_stream.py: cursor setter override type mismatch — add# type: ignore[override](matching existing ignore on the getter)\n\nRequested by: Aaron ("AJ") Steers (@aaronsteers)Link to Devin session: https://app.devin.ai/sessions/9f900ef4021147adb369727617d08827