Skip to content

fix: resolve MyPy type check failures#1045

Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
mainfrom
devin/1780716827-repro-mypy-ci-failures
Draft

fix: resolve MyPy type check failures#1045
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
mainfrom
devin/1780716827-repro-mypy-ci-failures

Conversation

@aaronsteers

@aaronsteers Aaron ("AJ") Steers (aaronsteers) commented Jun 6, 2026

Copy link
Copy Markdown
Member

Summary\n\nFixes 10 MyPy type check errors that fail in CI but not locally (likely due to CI using Python 3.10 + Poetry 1.8.4 with different dependency resolution):\n\n- checkpoint_reader.py: self.current_slice typed as StreamSlice | None — use local current variable after _find_next_slice() to avoid repeated property access through Optional type\n- utils.py / connector_builder_handler.py: Mapping.get() returns Any — wrap with bool() to satisfy -> bool return type\n- default_file_based_stream.py: cursor setter override type mismatch — add # type: ignore[override] (matching existing ignore on the getter)\n\nRequested by: Aaron ("AJ") Steers (@aaronsteers)

Link to Devin session: https://app.devin.ai/sessions/9f900ef4021147adb369727617d08827

Co-Authored-By: AJ Steers <aj@airbyte.io>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1780716827-repro-mypy-ci-failures#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1780716827-repro-mypy-ci-failures

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /prerelease - Triggers a prerelease publish with default arguments
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@devin-ai-integration devin-ai-integration Bot changed the title Do not merge: repro MyPy CI failures from main fix: resolve MyPy type check failures Jun 6, 2026
Co-Authored-By: AJ Steers <aj@airbyte.io>
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

PyTest Results (Fast)

4 094 tests  ±0   4 083 ✅ ±0   8m 17s ⏱️ -9s
    1 suites ±0      11 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 66dd637. ± Comparison against base commit a7b0929.

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

PyTest Results (Full)

4 097 tests  ±0   4 085 ✅ ±0   11m 31s ⏱️ -6s
    1 suites ±0      12 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 66dd637. ± Comparison against base commit a7b0929.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant