fix: strip null optional config fields before validation and include field path in error messages#1046
Closed
devin-ai-integration[bot] wants to merge 4 commits into
Closed
Conversation
…field path in error messages Config validation now strips null-valued non-required fields before running jsonschema validation. This prevents spurious 'None is not of type string' errors when the platform passes null for unset optional fields. Additionally, validation error messages now include the JSON path to the failing field, making config errors actionable for users. Co-Authored-By: gl_anatolii.yatsuk <gl_anatolii.yatsuk@airbyte.io>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1780998700-fix-config-null-validation#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1780998700-fix-config-null-validationPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Co-Authored-By: gl_anatolii.yatsuk <gl_anatolii.yatsuk@airbyte.io>
Uses Draft7Validator.iter_errors() to collect all config validation failures and reports them in a single error message separated by semicolons. Co-Authored-By: gl_anatolii.yatsuk <gl_anatolii.yatsuk@airbyte.io>
Co-Authored-By: gl_anatolii.yatsuk <gl_anatolii.yatsuk@airbyte.io>
Contributor
|
/prerelease
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes production config validation errors (
"Config validation error: None is not of type 'string'") affecting 103+ Amazon Seller Partner connections since 2026-06-08. The platform passes explicitnullfor unset optional config fields; JSON Schema rejectsnullunless the type includes"null", causing previously-working syncs to fail.Three changes to
check_config_against_spec_or_exit:Noneand which are not in the schema'srequiredlist. Absent keys are not validated by JSON Schema, so this correctly treats null-unset as absent-unset:Draft7Validator.iter_errors()instead ofvalidate()so all failing fields are reported at once, not just the first:ValidationError.absolute_pathso errors are actionable.Requested by @gl_anatolii.yatsuk via Metabase error dashboard.
Link to Devin session: https://app.devin.ai/sessions/24208f15bf9f4713bff165f51e1f18b3