Skip to content

fix: fix PrintBuffer logic #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artem Inzhyyants (artem1205) merged 3 commits into from
Mar 10, 2025
Merged

fix: fix PrintBuffer logic #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f8e0ac
fix: fix PrintBuffer logic
artem1205 Feb 13, 2025
c471c44
CDK: ref
artem1205 Feb 21, 2025
a5cabc2
Merge branch 'main' into artem1205/ref-print-buffer
artem1205 Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions airbyte_cdk/entrypoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

from airbyte_cdk.connector import TConfig
from airbyte_cdk.exception_handler import init_uncaught_exception_handler
from airbyte_cdk.logger import init_logger
from airbyte_cdk.logger import PRINT_BUFFER, init_logger
from airbyte_cdk.models import (
AirbyteConnectionStatus,
AirbyteMessage,
Expand Down Expand Up @@ -337,11 +337,11 @@ def launch(source: Source, args: List[str]) -> None:
parsed_args = source_entrypoint.parse_args(args)
# temporarily removes the PrintBuffer because we're seeing weird print behavior for concurrent syncs
# Refer to: https://github.com/airbytehq/oncall/issues/6235
# with PrintBuffer():
for message in source_entrypoint.run(parsed_args):
# simply printing is creating issues for concurrent CDK as Python uses different two instructions to print: one for the message and
# the other for the break line. Adding `\n` to the message ensure that both are printed at the same time
print(f"{message}\n", end="", flush=True)
with PRINT_BUFFER:
for message in source_entrypoint.run(parsed_args):
# simply printing is creating issues for concurrent CDK as Python uses different two instructions to print: one for the message and
# the other for the break line. Adding `\n` to the message ensure that both are printed at the same time
print(f"{message}\n", end="")


def _init_internal_request_filter() -> None:
Expand Down
5 changes: 4 additions & 1 deletion airbyte_cdk/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@
Level,
Type,
)
from airbyte_cdk.utils import PrintBuffer
from airbyte_cdk.utils.airbyte_secrets_utils import filter_secrets

PRINT_BUFFER = PrintBuffer(flush_interval=0.1)

LOGGING_CONFIG = {
"version": 1,
"disable_existing_loggers": False,
Expand All @@ -27,7 +30,7 @@
"handlers": {
"console": {
"class": "logging.StreamHandler",
"stream": "ext://sys.stdout",
Comment thread
artem1205 marked this conversation as resolved.
"stream": PRINT_BUFFER,
"formatter": "airbyte",
},
},
Expand Down