Skip to content

chore: run pyupgrade on codebase#479

Closed
Aaron ("AJ") Steers (aaronsteers) wants to merge 13 commits intomainfrom
devin/1744501562-pyupgrade-rules
Closed

chore: run pyupgrade on codebase#479
Aaron ("AJ") Steers (aaronsteers) wants to merge 13 commits intomainfrom
devin/1744501562-pyupgrade-rules

Conversation

@aaronsteers
Copy link
Copy Markdown
Member

This PR targets the following PR:


chore: run pyupgrade on codebase

What

Added UP rules to Ruff configuration and ran pyupgrade to upgrade Python syntax to be compatible with Python 3.10+.

Why

Keep the codebase using modern Python syntax and features. Adding the rules to Ruff will prevent old patterns from re-emerging.

How

  • Added UP rules to Ruff configuration
  • Used Ruff's auto-fix to address issues first
  • Also auto-fixed RUF013 (implicit-optional) issues in a separate commit
  • Ran pyupgrade manually to catch any remaining issues
  • Notable changes include replacing typing imports like List, Dict, Optional with built-in equivalents

Link to Devin run: https://app.devin.ai/sessions/b7644d2fc961450f81aeef7c10e062a5
Author: Aaron ("AJ") Steers (aj@airbyte.io)

devin-ai-integration bot and others added 10 commits April 12, 2025 06:46
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

Original prompt from Aaron:

@Devin - Create a CDK PR an run pyupgrade on it. Use me as the PR author. You'll need my PAT to create the PR.

@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the chore label Apr 13, 2025
devin-ai-integration bot and others added 3 commits April 13, 2025 03:33
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@aaronsteers Aaron ("AJ") Steers (aaronsteers) marked this pull request as draft April 14, 2025 16:53
Base automatically changed from devin/1744440307-update-ruff to main April 14, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant