Skip to content

feat: do not reset semaphore when duplicate partitions #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Serhii Lazebnyi (lazebnyi) merged 4 commits into from
Apr 26, 2025
Merged

feat: do not reset semaphore when duplicate partitions #509

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb612f9
do not reset semaphore when duplicate partitions
Apr 26, 2025
eeff98c
Auto-fix lint and format issues
Apr 26, 2025
9064376
Merge branch 'main' into maxi297/support-duplicate-partitions-in-per-…
maxi297 Apr 26, 2025
a4d853b
Fix logging
Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion airbyte_cdk/sources/declarative/incremental/concurrent_partition_cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ class ConcurrentPerPartitionCursor(Cursor):
_NO_CURSOR_STATE: Mapping[str, Any] = {}
_GLOBAL_STATE_KEY = "state"
_PERPARTITION_STATE_KEY = "states"
_IS_PARTITION_DUPLICATION_LOGGED = False
Comment thread
lazebnyi marked this conversation as resolved.
_KEY = 0
_VALUE = 1

Expand Down Expand Up @@ -279,7 +280,13 @@ def _generate_slices_from_partition(
with self._lock:
self._number_of_partitions += 1
self._cursor_per_partition[partition_key] = cursor
self._semaphore_per_partition[partition_key] = threading.Semaphore(0)

if partition_key in self._semaphore_per_partition:
if not self._IS_PARTITION_DUPLICATION_LOGGED:
logger.warning(f"Partition duplication detected for stream {self._stream_name}")
self._IS_PARTITION_DUPLICATION_LOGGED = True
else:
self._semaphore_per_partition[partition_key] = threading.Semaphore(0)

Comment thread
lazebnyi marked this conversation as resolved.
with self._lock:
if (
Expand Down
Loading