chore: set up asdf with .tool-versions#516
Closed
devin-ai-integration[bot] wants to merge 4 commits intomainfrom
Closed
chore: set up asdf with .tool-versions#516devin-ai-integration[bot] wants to merge 4 commits intomainfrom
.tool-versions#516devin-ai-integration[bot] wants to merge 4 commits intomainfrom
Conversation
…n workflows Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Contributor
Author
|
Original prompt from Aaron: |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Member
Aaron ("AJ") Steers (aaronsteers)
left a comment
There was a problem hiding this comment.
More places where matrix should have priority over tool versions file. I will apply these changes.
.tool-versions
| @@ -0,0 +1,2 @@ | |||
| python 3.11 | |||
Contributor
There was a problem hiding this comment.
some workflows are using 3.10 it seems. - worth testing to make sure this bump doesn't break anything. Similarly workflows are not all using the same poetry version
Also unless there's a good reason not to, I like that this makes all workflows use the same versions
Contributor
Author
|
Closing due to inactivity for more than 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note from AJ (Aaron ("AJ") Steers (@aaronsteers))
This is a spinoff from this Slack thread:
Idea is to keep things more DRY and reduce version drift for tools used in CI workflows.
In total, this PR replaces 20 hardcoded version refs for Python and/or Poetry, instead storing the version in a new
.tool-versionsfile which we can maintain centrally.I've reviewed this PR and I think it's ready for others to review as well, esp. Ben Church (@bnchrch) who's more experienced with asdf.
How
Link to GitHub Action docs:
marocchino/tool-versions-action, which scrapes the file and creates outputs we can pass to other steps.Do developers have to use
asdf?No. This step does not require everyone on the team to use
asdf. The scope here is just CI, and creating the local.tool-versionsfile. Developers can (if they want to) start usingasdf, but that is not required for this PR to have positive value, since the emphasis here is really just on CI.Generated Summary (Devin):
Set up asdf with .tool-versions
This PR adds a .tool-versions file containing the tool versions currently used in GitHub Actions workflows and updates the workflows to use the marocchino/tool-versions-action. This allows managing tool versions in a single place.
Changes:
Requested by: Aaron ("AJ") Steers (aj@airbyte.io)
Link to Devin run: https://app.devin.ai/sessions/faac6654afb44c50b895d7e768f7c9aa