Skip to content

chore: set up asdf with .tool-versions #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devin-ai-integration wants to merge 4 commits into from
Closed

chore: set up asdf with .tool-versions #516

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec45f6d
chore: set up asdf with .tool-versions and use tool-versions-action i…
devin-ai-integration[bot] Apr 28, 2025
a34a205
prefer matrix version
aaronsteers Apr 28, 2025
2e946cf
Apply suggestions from code review
aaronsteers Apr 28, 2025
4597c3c
skip version check if job canceled
aaronsteers Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/autofix-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,17 @@ jobs:

[1]: ${{ steps.vars.outputs.run-url }}

- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "2.0.1"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
python-version: ${{ steps.tool-versions.outputs.python }}
Comment thread
aaronsteers marked this conversation as resolved.
Outdated
cache: "poetry"
- name: Install dependencies
run: poetry install --all-extras
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/connector-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,13 @@ jobs:
repository: airbytehq/airbyte
ref: master
path: airbyte
- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.11"
python-version: ${{ steps.tool-versions.outputs.python }}
# Create initial pending status for test report
- name: Create Pending Test Report Status
if: steps.no_changes.outputs.status != 'cancelled'
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/pdoc_preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,17 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "2.0.1"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: ${{ steps.tool-versions.outputs.python }}
cache: "poetry"

- name: Install dependencies
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/pdoc_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,17 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "2.0.1"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: ${{ steps.tool-versions.outputs.python }}
cache: "poetry"
- name: Setup Pages
uses: actions/configure-pages@v5
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/poetry-lock-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,17 @@ jobs:

[1]: ${{ steps.vars.outputs.run-url }}

- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "2.0.1"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
python-version: ${{ steps.tool-versions.outputs.python }}
Comment thread
aaronsteers marked this conversation as resolved.
Outdated
cache: "poetry"

# Run `poetry lock`
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/pypi_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,12 @@ jobs:
IS_PRERELEASE: ${{ needs.build.outputs.IS_PRERELEASE }}
runs-on: ubuntu-24.04
steps:
- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: ${{ steps.tool-versions.outputs.python }}
- name: Checkout Airbyte Platform Internal
uses: actions/checkout@v4
with:
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/pytest_fast.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,13 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "2.0.1"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}

- name: Check Poetry lock file is current
run: poetry check
Expand All @@ -41,14 +44,17 @@ jobs:
# Common steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "2.0.1"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: ${{ steps.tool-versions.outputs.python }}
cache: "poetry"
- name: Install dependencies
run: poetry install --all-extras
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/pytest_matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,20 @@ jobs:
- 'bin/**'
- 'poetry.lock'
- 'pyproject.toml'
- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
if: steps.changes.outputs.src == 'true'
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
if: steps.changes.outputs.src == 'true'
with:
poetry-version: "2.0.1"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Set up Python
uses: actions/setup-python@v5
if: steps.changes.outputs.src == 'true'
with:
python-version: ${{ matrix.python-version }}
python-version: ${{ steps.tool-versions.outputs.python }}
Comment thread
aaronsteers marked this conversation as resolved.
Outdated
cache: "poetry"
- name: Install dependencies
if: steps.changes.outputs.src == 'true'
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/python_dependency_analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,17 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: ${{ steps.tool-versions.outputs.python }}
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "2.0.1"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Install dependencies
run: poetry install --all-extras

Expand Down
21 changes: 15 additions & 6 deletions .github/workflows/python_lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,17 @@ jobs:
# Common steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "2.0.1"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: ${{ steps.tool-versions.outputs.python }}
cache: "poetry"
- name: Install dependencies
run: poetry install --all-extras
Expand All @@ -37,14 +40,17 @@ jobs:
# Common steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "1.8.4"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: ${{ steps.tool-versions.outputs.python }}
cache: "poetry"
- name: Install dependencies
run: poetry install --all-extras
Expand All @@ -60,14 +66,17 @@ jobs:
# Common steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "1.8.4"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: ${{ steps.tool-versions.outputs.python }}
cache: "poetry"
- name: Install dependencies
run: poetry install --all-extras
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/test-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,17 @@ jobs:

# Same as the `python_pytest.yml` file:

- name: Get tool versions
uses: marocchino/tool-versions-action@v1
id: tool-versions
- name: Set up Poetry
uses: Gr1N/setup-poetry@v9
with:
poetry-version: "2.0.1"
poetry-version: ${{ steps.tool-versions.outputs.poetry }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
python-version: ${{ steps.tool-versions.outputs.python }}
Comment thread
aaronsteers marked this conversation as resolved.
Outdated
cache: "poetry"
- name: Install dependencies
run: poetry install --all-extras
Expand Down
2 changes: 2 additions & 0 deletions .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
python 3.11

@dbgold17 David Gold (dbgold17) Apr 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some workflows are using 3.10 it seems. - worth testing to make sure this bump doesn't break anything. Similarly workflows are not all using the same poetry version

Also unless there's a good reason not to, I like that this makes all workflows use the same versions

poetry 2.0.1