Skip to content

fix: (CDK) (Manifest Migration) - correct the migration versions to v6.48.2#518

Merged
Baz (bazarnov) merged 1 commit intomainfrom
baz/cdk/fix-migration-versions
Apr 29, 2025
Merged

fix: (CDK) (Manifest Migration) - correct the migration versions to v6.48.2#518
Baz (bazarnov) merged 1 commit intomainfrom
baz/cdk/fix-migration-versions

Conversation

@bazarnov
Copy link
Copy Markdown
Contributor

@bazarnov Baz (bazarnov) commented Apr 29, 2025

What

After this PR, there is a need to correct the migration version from 6.48.0 > 6.48.2 to align the functionality with the deprecations.

Summary by CodeRabbit

  • Chores
    • Updated migration version identifiers from 6.48.0 to 6.48.2 in registry and related test data.

@bazarnov Baz (bazarnov) self-assigned this Apr 29, 2025
Copilot AI review requested due to automatic review settings April 29, 2025 11:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates migration version numbers from "6.48.0" to "6.48.2" to align with deprecation changes. The changes update tests in the manifest migration fixtures and adjust the migration registry accordingly.

  • Updated test fixtures in unit_tests/manifest_migrations/conftest.py
  • Updated migration registry in airbyte_cdk/manifest_migrations/migrations/registry.yaml

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
unit_tests/manifest_migrations/conftest.py Updated manifest fixtures and applied_migrations version numbers from "6.48.0" to "6.48.2"
airbyte_cdk/manifest_migrations/migrations/registry.yaml Updated migration registry version from "6.48.0" to "6.48.2"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 29, 2025

📝 Walkthrough

Walkthrough

The changes update the migration version identifier from 6.48.0 to 6.48.2 in both the manifest migrations registry file and related unit test fixtures. No other modifications to structure, migration steps, or data were made; the updates are limited to version number increments in both the production and test files.

Changes

File(s) Change Summary
airbyte_cdk/manifest_migrations/migrations/registry.yaml Updated migration version identifier from 6.48.0 to 6.48.2.
unit_tests/manifest_migrations/conftest.py Updated version strings in test fixtures from 6.48.0 to 6.48.2; no structural or logic changes.

Suggested labels

chore

Would you like to consider adding a label like version-update as well, or does chore capture your intent best—wdyt?


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b9f4736 and 37f80a8.

📒 Files selected for processing (2)
  • airbyte_cdk/manifest_migrations/migrations/registry.yaml (1 hunks)
  • unit_tests/manifest_migrations/conftest.py (5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: Check: 'source-pokeapi' (skip=false)
  • GitHub Check: Check: 'source-amplitude' (skip=false)
  • GitHub Check: Check: 'source-shopify' (skip=false)
  • GitHub Check: Check: 'source-hardcoded-records' (skip=false)
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
  • GitHub Check: Pytest (Fast)
  • GitHub Check: SDM Docker Image Build
  • GitHub Check: Analyze (python)
🔇 Additional comments (6)
airbyte_cdk/manifest_migrations/migrations/registry.yaml (1)

6-6:

Details

✅ Verification successful

Confirm migration version bump in registry
The version was correctly updated to 6.48.2 to align with the intended manifest migration. Could we also search for any remaining "6.48.0" references in the codebase to be thorough? wdyt?


🏁 Script executed:

#!/bin/bash
# Verify no stray references to the old version
rg '"6.48.0"'

Length of output: 15


Confirm no stray "6.48.0" references
Ran rg '"6.48.0"' across the repo and found no matches—looks like the bump to 6.48.2 is fully applied. All set! wdyt?

unit_tests/manifest_migrations/conftest.py (5)

200-200: Validate version bump in expected_manifest_with_url_base_migrated_to_url
The top‐level "version" key has been updated to "6.48.2" and matches the registry entry. wdyt?


497-497: Approve to_version updates in applied migrations
Both "to_version" fields within applied_migrations have been updated to "6.48.2" as expected. Thanks for keeping these in sync!

Also applies to: 503-503


515-515: Confirm version bump in manifest_with_migrated_url_base_and_path_is_joined_to_url
The fixture’s "version" key correctly reflects the new 6.48.2.


825-825: Confirm version bump in expected_manifest_with_migrated_to_request_body
The top-level "version" is now "6.48.2" and aligns with the other fixtures.


1181-1181: Approve all to_version entries in expected_manifest_with_migrated_to_request_body
All three "to_version" fields for the applied migrations have been updated to 6.48.2, keeping the test metadata consistent.

Also applies to: 1187-1187, 1193-1193

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bazarnov Baz (bazarnov) merged commit a1dd40b into main Apr 29, 2025
26 of 28 checks passed
@bazarnov Baz (bazarnov) deleted the baz/cdk/fix-migration-versions branch April 29, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants