Skip to content

feat(cdk): allow empty secrets (bing-ads) #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aldo Gonzalez (aldogonzalez8) merged 6 commits into from
Apr 30, 2025
Merged

feat(cdk): allow empty secrets (bing-ads) #519

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b6c856
mlc: allow empty secrets (bing-ads)
aldogonzalez8 Apr 29, 2025
4e0ebc4
Auto-fix lint and format issues
Apr 29, 2025
036e709
Merge branch 'main' into ac8/allow-empty-secrets
aldogonzalez8 Apr 30, 2025
63ade32
document client secret empty
aldogonzalez8 Apr 30, 2025
b9d1930
Merge branch 'main' into ac8/allow-empty-secrets
aldogonzalez8 Apr 30, 2025
aec8361
add unit tests
aldogonzalez8 Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions airbyte_cdk/sources/declarative/auth/oauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#

import logging
from dataclasses import InitVar, dataclass, field
from datetime import datetime, timedelta
from typing import Any, List, Mapping, MutableMapping, Optional, Union
from typing import Any, List, Mapping, Optional, Union

from airbyte_cdk.sources.declarative.auth.declarative_authenticator import DeclarativeAuthenticator
from airbyte_cdk.sources.declarative.interpolation.interpolated_boolean import InterpolatedBoolean
Expand All @@ -19,6 +20,8 @@
)
from airbyte_cdk.utils.datetime_helpers import AirbyteDateTime, ab_datetime_now, ab_datetime_parse

logger = logging.getLogger("airbyte")


@dataclass
class DeclarativeOauth2Authenticator(AbstractOauth2Authenticator, DeclarativeAuthenticator):
Expand Down Expand Up @@ -201,7 +204,10 @@ def get_client_secret(self) -> str:
self._client_secret.eval(self.config) if self._client_secret else self._client_secret
)
if not client_secret:
raise ValueError("OAuthAuthenticator was unable to evaluate client_secret parameter")
# We've seen some APIs allowing empty client_secret so we will only log here
logger.warning(
"OAuthAuthenticator was unable to evaluate client_secret parameter hence it'll be empty"
)
return client_secret # type: ignore # value will be returned as a string, or an error will be raised

def get_refresh_token_name(self) -> str:
Expand Down
Loading