chore: update .gitignore to not commit junit results#588
Conversation
📝 WalkthroughWalkthroughThe Changes
Would you like to consider adding patterns for other common build or test artifact directories, such as Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.gitignore (1)
1-3: New ignore rules for build and test-results directories
These entries will skip allbuildandtest-resultspaths, which is great to keep artifacts out of Git. Would you consider adding trailing slashes (e.g.build/andtest-results/) to explicitly mark them as directories and avoid unintentionally ignoring files named “build”? wdyt?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.gitignore(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: MyPy Check
- GitHub Check: Pytest (Fast)
- GitHub Check: SDM Docker Image Build
- GitHub Check: preview_docs
- GitHub Check: Analyze (python)
- GitHub Check: Analyze (actions)
|
Something flaky appears to be happening here: https://github.com/airbytehq/airbyte-python-cdk/actions/runs/15497060794/job/43636202348
This only failed in the fast tests, not in the full tests, and the PR doesn't change any code. |
f398ab6
into
main

Summary by CodeRabbit
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.