feat: adds dateparser dependency for parsing timezone abbrs.#636
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the dateparser library to enable parsing of date strings with timezone abbreviations returned by certain endpoints.
- Adds
dateparseras a direct dependency. - Enables downstream connectors (e.g., Amazon Seller Partner) to handle timezone‐abbreviated dates.
Comments suppressed due to low confidence (2)
pyproject.toml:94
- [nitpick] Consider updating the project README or changelog to mention the addition of
dateparserand the new support for parsing timezone‐abbreviated dates.
dateparser = "^1.2.2"
pyproject.toml:94
- Add or update unit tests to verify that date strings with timezone abbreviations are correctly parsed using the new
dateparserdependency.
dateparser = "^1.2.2"
Patrick Nilan (pnilan)
changed the title
dateparser dependency for parsing timezone abbrs.
Contributor
📝 WalkthroughWalkthroughA new dependency, Changes
Sequence Diagram(s)No sequence diagram generated, as the change is limited to dependency management. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dateparserdependency for parsing timezone abbrs.dateparserrepo here: https://github.com/scrapinghub/dateparserWhy
source-amazon-seller-partnerbecause one endpoint likes returning dates with timezone abbreviations appended to the end of the string.dateparserrepo appears to be regularly maintained.Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.
Summary by CodeRabbit