fix: revert "fix: properly join url and path when calculating full url (#6…#696
Closed
Lake Mossman (lmossman) wants to merge 1 commit into
Closed
fix: revert "fix: properly join url and path when calculating full url (#6…#696Lake Mossman (lmossman) wants to merge 1 commit into
Lake Mossman (lmossman) wants to merge 1 commit into
Conversation
…)" This reverts commit 950acc6.
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@lmossman/revert-url-joining-change#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch lmossman/revert-url-joining-changeHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
PyTest Results (Fast)3 695 tests - 4 3 684 ✅ - 4 6m 26s ⏱️ -3s Results for commit 513fef1. ± Comparison against base commit db1e4c0. This pull request removes 4 tests. |
PyTest Results (Full)3 698 tests - 4 3 687 ✅ - 4 11m 44s ⏱️ +4s Results for commit 513fef1. ± Comparison against base commit db1e4c0. This pull request removes 4 tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…92)"
This reverts commit 950acc6.