Skip to content

fix: revert "fix: properly join url and path when calculating full url (#6…#696

Closed
Lake Mossman (lmossman) wants to merge 1 commit into
mainfrom
lmossman/revert-url-joining-change
Closed

fix: revert "fix: properly join url and path when calculating full url (#6…#696
Lake Mossman (lmossman) wants to merge 1 commit into
mainfrom
lmossman/revert-url-joining-change

Conversation

@lmossman

Copy link
Copy Markdown
Contributor

…92)"

This reverts commit 950acc6.

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@lmossman/revert-url-joining-change#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch lmossman/revert-url-joining-change

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

@lmossman Lake Mossman (lmossman) changed the title Revert "fix: properly join url and path when calculating full url (#6… fix: revert "fix: properly join url and path when calculating full url (#6… Aug 5, 2025
@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown

PyTest Results (Fast)

3 695 tests   - 4   3 684 ✅  - 4   6m 26s ⏱️ -3s
    1 suites ±0      11 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 513fef1. ± Comparison against base commit db1e4c0.

This pull request removes 4 tests.
unit_tests.sources.declarative.requesters.test_http_requester ‑ test_join_url_with_url_and_path[test_no_path-https://airbyte.io/my_endpoint-None-https://airbyte.io/my_endpoint]
unit_tests.sources.declarative.requesters.test_http_requester ‑ test_join_url_with_url_and_path[test_path_does_include_url-https://airbyte.io/my_endpoint-https://airbyte.io/my_endpoint/with_path-https://airbyte.io/my_endpoint/with_path]
unit_tests.sources.declarative.requesters.test_http_requester ‑ test_join_url_with_url_and_path[test_path_does_not_include_url-https://airbyte.io/my_endpoint-with_path-https://airbyte.io/my_endpoint/with_path]
unit_tests.sources.declarative.requesters.test_http_requester ‑ test_join_url_with_url_and_path[test_path_is_different_full_url-https://airbyte.io/my_endpoint-https://airbyte-paginated.io/my_paginated_endpoint-https://airbyte-paginated.io/my_paginated_endpoint]

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown

PyTest Results (Full)

3 698 tests   - 4   3 687 ✅  - 4   11m 44s ⏱️ +4s
    1 suites ±0      11 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 513fef1. ± Comparison against base commit db1e4c0.

This pull request removes 4 tests.
unit_tests.sources.declarative.requesters.test_http_requester ‑ test_join_url_with_url_and_path[test_no_path-https://airbyte.io/my_endpoint-None-https://airbyte.io/my_endpoint]
unit_tests.sources.declarative.requesters.test_http_requester ‑ test_join_url_with_url_and_path[test_path_does_include_url-https://airbyte.io/my_endpoint-https://airbyte.io/my_endpoint/with_path-https://airbyte.io/my_endpoint/with_path]
unit_tests.sources.declarative.requesters.test_http_requester ‑ test_join_url_with_url_and_path[test_path_does_not_include_url-https://airbyte.io/my_endpoint-with_path-https://airbyte.io/my_endpoint/with_path]
unit_tests.sources.declarative.requesters.test_http_requester ‑ test_join_url_with_url_and_path[test_path_is_different_full_url-https://airbyte.io/my_endpoint-https://airbyte-paginated.io/my_paginated_endpoint-https://airbyte-paginated.io/my_paginated_endpoint]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant