chore(deps): Update whenever package version#759
chore(deps): Update whenever package version#759Aaron ("AJ") Steers (aaronsteers) merged 2 commits intoairbytehq:mainfrom
Conversation
📝 WalkthroughWalkthroughThe PR removes unused type imports from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Would you like me to run a quick compatibility scan for Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
airbyte_cdk/utils/datetime_helpers.py (2)
85-85: Import clean-up LGTM.Dropping Optional/Never aligns with current annotations; no functionality change. Shall we also remove the unnecessary Union in a few hints in favor of | for consistency, or keep as-is for readability, wdyt?
88-89: Add version constraint comment forInstantusageInstant.from_timestamp, Instant.from_utc, and py_datetime are confirmed available in whenever 0.7.x–0.8.8; could you add a brief comment linking this import to the matching version constraint in pyproject.toml for future clarity? wdyt?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
airbyte_cdk/utils/datetime_helpers.py(1 hunks)pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Pytest (All, Python 3.13, Ubuntu)
- GitHub Check: Pytest (Fast)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (All, Python 3.12, Ubuntu)
- GitHub Check: SDM Docker Image Build
- GitHub Check: Manifest Server Docker Image Build
🔇 Additional comments (1)
pyproject.toml (1)
96-96: Approve whenever version bumppoetry.lock locks whenever to 0.8.8 (within >=0.7.3,<0.9.0) and no imports of removed symbols (LocalDateTime/ZonedDateTime) remain—looks safe to merge. All set?
|
/test
|
|
bosper351 - Thank you for this contribution! 🙏 |
20d8b3f
into
airbytehq:main
Update
wheneverpackage and remove unused imports. Currently this blocks usingairbyte-cdkand PyAirbyte with Prefect.Summary by CodeRabbit