Skip to content

chore: regenerate autogenerated artifacts via poe build#818

Closed
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit intomainfrom
devin/1761595197-rerun-build-task
Closed

chore: regenerate autogenerated artifacts via poe build#818
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit intomainfrom
devin/1761595197-rerun-build-task

Conversation

@aaronsteers
Copy link
Copy Markdown
Member

@aaronsteers Aaron ("AJ") Steers (aaronsteers) commented Oct 27, 2025

chore: regenerate autogenerated artifacts via poe build

Summary

Reran the poe build task to regenerate autogenerated artifacts in the Python CDK. The build task identified drift in declarative_component_schema.py where a copyright header had been manually added to an autogenerated file. The file is now correctly regenerated without the copyright header, matching the expected output from datamodel-codegen.

The change removes 2 lines:

  • Copyright header comment
  • Blank line

Review & Testing Checklist for Human

  • Verify that removing the copyright header from this autogenerated file is the intended fix for the drift issue
  • Confirm that no other files should have been regenerated by the build task

Notes

Summary by CodeRabbit

  • Chores
    • Minor code maintenance performed.

Co-Authored-By: AJ Steers <aj@airbyte.io>
Copilot AI review requested due to automatic review settings October 27, 2025 20:03
@devin-ai-integration
Copy link
Copy Markdown
Contributor

Original prompt from AJ Steers
Received message in Slack channel #ask-devin-ai:

@Devin - can you create a PR against the python CDK that simply reruns the `build` poe task for autogenerated artifacts? Looks like we may have some drift.
Thread URL: https://airbytehq-team.slack.com/archives/C08BHPUMEPJ/p1761595112915229?thread_ts=1761595112.915229

@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1761595197-rerun-build-task#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1761595197-rerun-build-task

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes manual modifications from an autogenerated file to restore it to its correct generated state. The poe build task detected drift where a copyright header had been manually added to declarative_component_schema.py, which is generated by datamodel-codegen and should not contain manual additions.

Key Changes

  • Removed manually added copyright header from autogenerated file
  • Restored file to match expected output from code generation tooling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the chore label Oct 27, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 27, 2025

📝 Walkthrough

Walkthrough

The copyright header was removed from the declarative component schema Python file. No functional or behavioral changes were made to the file's code or logic.

Changes

Cohort / File(s) Change Summary
Copyright header removal
airbyte_cdk/sources/declarative/models/declarative_component_schema.py
Removed top copyright header lines

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "chore: regenerate autogenerated artifacts via poe build" directly and accurately describes the main change in the changeset. The pull request reruns the build task to regenerate an autogenerated file, removing manually-added copyright headers that introduced drift, which is exactly what the title communicates. The title is concise, uses appropriate conventions (chore prefix), and is specific enough that a teammate reviewing git history would understand this is a maintenance task to restore autogenerated files to their expected state.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/1761595197-rerun-build-task

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0ae1c0 and c90afee.

📒 Files selected for processing (1)
  • airbyte_cdk/sources/declarative/models/declarative_component_schema.py (0 hunks)
💤 Files with no reviewable changes (1)
  • airbyte_cdk/sources/declarative/models/declarative_component_schema.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: Check: destination-motherduck
  • GitHub Check: Check: source-intercom
  • GitHub Check: Check: source-shopify
  • GitHub Check: Check: source-pokeapi
  • GitHub Check: Check: source-hardcoded-records
  • GitHub Check: Pytest (Fast)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.13, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Manifest Server Docker Image Build
  • GitHub Check: SDM Docker Image Build
  • GitHub Check: Pytest (All, Python 3.12, Ubuntu)

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants