ci: fix release drafter race condition#871
Conversation
Co-Authored-By: AJ Steers <aj@airbyte.io>
Original prompt from AJ Steers |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Pull request overview
Fixes a race condition in the release-drafter workflow that causes merged PRs to be missing from draft release notes when multiple PRs merge simultaneously.
Key Changes:
- Add concurrency control to serialize workflow runs and prevent race conditions
- Pin release-drafter action to v6.0.0 to avoid duplicate draft release bug in v6.1.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1767309501-fix-release-drafter-race-condition#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1767309501-fix-release-drafter-race-conditionHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
📝 WalkthroughWalkthroughA GitHub Actions workflow configuration update that introduces concurrency control to prevent concurrent release-drafter runs and pins the release-drafter action to v6.0.0 from v6 to address a specific bug. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes a race condition in the release-drafter workflow where merged PRs sometimes don't appear in the draft release notes when multiple PRs merge in quick succession.
Changes:
concurrencygroup withcancel-in-progress: falseto queue (not cancel) overlapping runs@v6.0.0to avoid v6.1.0 bug where the action fails to find existing draft releases and creates duplicatesNote: Uses
release-drafter-${{ github.ref }}for the concurrency group since this workflow has bothpushandpull_requesttriggers, ensuring PR runs don't block each other while still serializing runs on the same ref.Review & Testing Checklist for Human
Notes
airbyte-ops-mcp,awesome-python-template,airbyte-interop-catalog, and several other reposImportant
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.