Skip to content

fix: do not advertise incremental sync mode for streams without cursor field #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaron ("AJ") Steers (aaronsteers) merged 2 commits into from
Jan 8, 2026
Merged

fix: do not advertise incremental sync mode for streams without cursor field #876

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef12f55
fix: do not advertise incremental sync mode for streams without curso…
devin-ai-integration[bot] Jan 8, 2026
3c36c8e
style: wrap ternary expression in parentheses for better readability
devin-ai-integration[bot] Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2110,11 +2110,11 @@ def create_default_stream(
name=stream_name,
json_schema=schema_loader.get_json_schema,
primary_key=get_primary_key_from_stream(primary_key),
cursor_field=concurrent_cursor.cursor_field
if hasattr(concurrent_cursor, "cursor_field")
else CursorField(
cursor_field_key=""
), # FIXME we should have the cursor field has part of the interface of cursor,
cursor_field=(
concurrent_cursor.cursor_field
if hasattr(concurrent_cursor, "cursor_field")
else None
),
logger=logging.getLogger(f"airbyte.{stream_name}"),
cursor=concurrent_cursor,
supports_file_transfer=hasattr(model, "file_uploader") and bool(model.file_uploader),
Expand Down
Loading