Skip to content

fix(test): allow write access to config file in Docker tests #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaron ("AJ") Steers (aaronsteers) merged 1 commit into from
Jan 16, 2026
Merged

fix(test): allow write access to config file in Docker tests #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions airbyte_cdk/test/models/scenario.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,10 @@ def with_temp_config_file(
) as temp_file:
temp_file.write(json.dumps(config))
temp_file.flush()
# Allow the file to be read by other processes
# Allow the file to be read and written by other processes
# Write access is needed for connectors with config migration (e.g., OAuth token refresh)
temp_path = Path(temp_file.name)
temp_path.chmod(temp_path.stat().st_mode | 0o444)
temp_path.chmod(temp_path.stat().st_mode | 0o666)
yield temp_path

# attempt cleanup, ignore errors
Expand Down
6 changes: 3 additions & 3 deletions airbyte_cdk/test/standard_tests/docker_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def test_docker_image_build_and_check(
"run",
"--rm",
"-v",
f"{temp_config_file}:{container_config_path}",
f"{temp_config_file}:{container_config_path}:rw",
connector_image,
"check",
"--config",
Expand Down Expand Up @@ -336,7 +336,7 @@ def test_docker_image_build_and_read(
"run",
"--rm",
"-v",
f"{temp_config_file}:{container_config_path}",
f"{temp_config_file}:{container_config_path}:rw",
connector_image,
"discover",
"--config",
Expand Down Expand Up @@ -393,7 +393,7 @@ def test_docker_image_build_and_read(
"run",
"--rm",
"-v",
f"{temp_config_file}:{container_config_path}",
f"{temp_config_file}:{container_config_path}:rw",
"-v",
f"{configured_catalog_path}:{container_catalog_path}",
connector_image,
Expand Down
Loading