chore: increase MAX_CONNECTION_POOL_SIZE from 20 to 40#926
Conversation
Co-Authored-By: unknown <>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1772449759-increase-max-connection-pool-size#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1772449759-increase-max-connection-pool-sizePR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
|
/prerelease
|
|
/prerelease
|
|
❌ Cannot revive Devin session - the session is too old. Please start a new session instead. |
There was a problem hiding this comment.
Pull request overview
Increases the default HTTP connection pool size to better match connectors that can run with higher concurrency, avoiding urllib3 “Connection pool is full” warnings and improving connection reuse.
Changes:
- Bumped
MAX_CONNECTION_POOL_SIZEfrom 20 → 40 in the shared HTTP config. - Updated two unit tests that assert the configured connection pool size.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
airbyte_cdk/sources/http_config.py |
Raises the shared connection pool size constant used by the HTTP client adapter. |
unit_tests/sources/streams/http/test_http.py |
Updates the expected adapter pool configuration assertion. |
unit_tests/sources/streams/http/test_http_client.py |
Updates the expected adapter pool configuration assertion for HttpClient. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ease-max-connection-pool-size
|
/prerelease
|
Summary
Increases
MAX_CONNECTION_POOL_SIZEfrom 20 to 40 inairbyte_cdk/sources/http_config.pyand updates the two corresponding test assertions.With connectors now supporting
max_concurrencyup to 40 (e.g., source-intercom PR), the previous pool size of 20 causes urllib3 warnings:Connections still succeed but bypass the pool (no reuse), reducing efficiency. This change aligns the pool size with the maximum concurrency connectors can configure.
Review & Testing Checklist for Human
max_concurrencysetting) rather than a static increase — the existing comment inhttp_config.pyalready notes this as a future improvementNotes
Requested by: gl_anatolii.yatsuk
Devin session