fix: pass stream_slicer when creating retriever in DynamicSchemaLoader#974
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Conversation
In create_dynamic_schema_loader, the retriever was created with only partition_router but not stream_slicer. This caused AsyncRetriever creation to fail with 'missing required keyword-only argument: stream_slicer' since AsyncRetriever requires stream_slicer as a keyword-only argument while SimpleRetriever accepts partition_router. The fix mirrors the pattern used in create_default_stream, passing both stream_slicer and partition_router when creating the retriever. Resolves #766 Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1775066638-fix-dynamic-schema-loader-async-retriever#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1775066638-fix-dynamic-schema-loader-async-retrieverPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_dynamic_schema_loaderinModelToComponentFactoryfailed withTypeError: missing 1 required keyword-only argument: 'stream_slicer'when the retriever was anAsyncRetriever. This is becauseAsyncRetrieverrequiresstream_sliceras a keyword-only argument, but onlypartition_routerwas being passed.The fix passes both
stream_slicerandpartition_routerwhen creating the retriever, mirroring the existing pattern increate_default_stream(line ~2086).Resolves https://github.com/airbytehq/oncall/issues/11848:
Resolves #766:
Review & Testing Checklist for Human
stream_slicer=partition_routerpattern increate_dynamic_schema_loadermatches the established pattern increate_default_stream— both should passstream_slicerandpartition_routerwith the same valuepytest unit_tests/sources/declarative/parsers/test_model_to_component_factory.py::test_dynamic_schema_loader_with_async_retriever)Notes
TypeErrorbut does not exercise the full DynamicSchemaLoader + AsyncRetriever data path.create_http_components_resolveralready correctly passesstream_slicer.Link to Devin session: https://app.devin.ai/sessions/1035eef80d1f48f6ab01e96589caedb1