Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions airbyte_cdk/sources/streams/http/rate_limiting.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,19 +106,22 @@ def user_defined_backoff_handler(
def sleep_on_ratelimit(details: Mapping[str, Any]) -> None:
_, exc, _ = sys.exc_info()
if isinstance(exc, UserDefinedBackoffException):
retry_after = exc.backoff
if exc.response:
logger.info(
f"Status code: {exc.response.status_code!r}, Response Content: {exc.response.content!r}"
f"UserDefinedBackoffException: Rate limit exceeded (HTTP {exc.response.status_code}). Retrying in {retry_after} seconds."
)
else:
logger.info(
f"UserDefinedBackoffException: Rate limit exceeded. Retrying in {retry_after} seconds."
Comment thread
sophiecuiy marked this conversation as resolved.
Outdated
)
retry_after = exc.backoff
logger.info(f"Retrying. Sleeping for {retry_after} seconds")
time.sleep(retry_after + 1) # extra second to cover any fractions of second
Comment thread
sophiecuiy marked this conversation as resolved.
Outdated

def log_give_up(details: Mapping[str, Any]) -> None:
_, exc, _ = sys.exc_info()
if isinstance(exc, RequestException):
logger.error(
f"Max retry limit reached in {details['elapsed']}s. Request: {exc.request}, Response: {exc.response}"
f"Max retry limit reached after {details['elapsed']:.1f}s. Request: {exc.request}, Response: {exc.response}"
)
else:
logger.error("Max retry limit reached for unknown request and response")
Expand All @@ -132,6 +135,7 @@ def log_give_up(details: Mapping[str, Any]) -> None:
jitter=None,
max_tries=max_tries,
max_time=max_time,
logger=None, # suppress the backoff library's default log that misleadingly reports interval (0s) instead of actual sleep time
**kwargs,
)
Comment thread
sophiecuiy marked this conversation as resolved.

Expand Down
Loading