Skip to content

fix(source-monday): Add WaitTimeFromHeader backoff strategy#48597

Closed
Anatolii Yatsuk (tolik0) wants to merge 19 commits into
masterfrom
tolik0/source-monday/add-wait-time-from-header-backoff
Closed

fix(source-monday): Add WaitTimeFromHeader backoff strategy#48597
Anatolii Yatsuk (tolik0) wants to merge 19 commits into
masterfrom
tolik0/source-monday/add-wait-time-from-header-backoff

Conversation

@tolik0
Copy link
Copy Markdown
Contributor

@tolik0 Anatolii Yatsuk (tolik0) commented Nov 21, 2024

What

Added WaitTimeFromHeader backoff strategy to handle retries using the retry-after header, improving efficiency and aligning with rate-limit resets.
Oncall: https://github.com/airbytehq/oncall/issues/6858

How

Updated manifest.yaml with WaitTimeFromHeader and fallback ConstantBackoffStrategy.

User Impact

Improved retry logic: Reduces unnecessary delays.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2025 1:30pm

@ianmeigh
Copy link
Copy Markdown

Hi all, I saw this PR was approved a while back but hasn’t been merged yet. I was just wondering if there’s a timeline for merging this into the main branch for release or if there are any blockers that still need to be addressed.

This would be really useful to address a problem I am experiencing in my project. I’d love to know if there’s anything I can do to help move it forward. I appreciate all the work that’s gone into this!

@aldogonzalez8
Copy link
Copy Markdown
Contributor

Hi all, I saw this PR was approved a while back but hasn’t been merged yet. I was just wondering if there’s a timeline for merging this into the main branch for release or if there are any blockers that still need to be addressed.

This would be really useful to address a problem I am experiencing in my project. I’d love to know if there’s anything I can do to help move it forward. I appreciate all the work that’s gone into this!

Ian (@ianmeigh) Let me check if I can update this PR and get it merged.

@aldogonzalez8
Copy link
Copy Markdown
Contributor

This will likely have to be force merged since the pyairbyte test requires 3.10, but we will be using 3.9 for a little longer until we bump this to cdk 6 next week according to this.

cc Natik Gadzhi (@natikgadzhi) Maxime Carbonneau-Leclerc (@maxi297) with super powers.

@maxi297
Copy link
Copy Markdown
Contributor

Aldo Gonzalez (@aldogonzalez8) should we run a bunch of regression tests to double check then? Else, how far off is the update to cdk version 6? I know Anatolii Yatsuk (@tolik0) had this in a PR soon to be merged

@aldogonzalez8
Copy link
Copy Markdown
Contributor

how far off is the update to cdk version 6? I know Anatolii Yatsuk (@tolik0) had this in a PR soon to be merged

I would be interested, as this could be included, or at least we could hold to see this test passing. Anatolii Yatsuk (@tolik0) how far are we to update to cdk version 6?

Aldo Gonzalez (@aldogonzalez8) should we run a bunch of regression tests to double check then?

I can do it if we are not close to bum CDK v6. In the meantime, let me see if I can put something quick to run anyway.

@maxi297
Copy link
Copy Markdown
Contributor

Ian (@ianmeigh) , this feature should have been added here as part of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/monday

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants