feat(source-hubspot): contacts form submissions and contacts merged audits to low code#57560
Closed
Daryna Ishchenko (darynaishchenko) wants to merge 4 commits into
Conversation
Daryna Ishchenko (darynaishchenko)
requested a review
from a team
as a code owner
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
|
|
||
| @dataclass | ||
| class UnnestFields(RecordTransformation): |
Collaborator
Author
There was a problem hiding this comment.
this can be removed after this changes are merged airbytehq/airbyte-python-cdk#472
| type: RecordSelector | ||
| transform_before_filtering: true | ||
| record_filter: | ||
| type: RecordFilter |
Contributor
There was a problem hiding this comment.
maybe this is a question for later post-migration, but it seems like this should've just been a client side incremental stream
Collaborator
Author
There was a problem hiding this comment.
yes, it it should be client-side incremental in this case. I migrated current stream's implementation. Should I create an issue to track streams like this and update them after low-code migration?
Collaborator
Author
|
streams will be deprecated in #59673 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?