feat(ci): add dockerimage files in new docker-images directory#59193
Merged
Aaron ("AJ") Steers (aaronsteers) merged 5 commits intoMay 2, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Aaron ("AJ") Steers (aaronsteers)
changed the title
docker-images directorydocker-images directory
Aaron ("AJ") Steers (aaronsteers)
requested review from
Copilot and
Davin Chia (davinchia)
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR adds a new directory "docker-images" containing Dockerfile resources and documentation for building Docker connector images.
- Introduces a README.md with build instructions and explanations for Docker image definitions.
Files not reviewed (9)
- docker-images/Dockerfile.java-connector: Language not supported
- docker-images/Dockerfile.java-connector-base: Language not supported
- docker-images/Dockerfile.java-connector.dockerignore: Language not supported
- docker-images/Dockerfile.manifest-only-connector: Language not supported
- docker-images/Dockerfile.manifest-only-connector-base: Language not supported
- docker-images/Dockerfile.manifest-only-connector.dockerignore: Language not supported
- docker-images/Dockerfile.python-connector: Language not supported
- docker-images/Dockerfile.python-connector-base: Language not supported
- docker-images/Dockerfile.python-connector.dockerignore: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Davin Chia (davinchia)
approved these changes
May 1, 2025
Contributor
Davin Chia (davinchia)
left a comment
Davin Chia (davinchia)
left a comment
There was a problem hiding this comment.
No comment on the non-Java build files. Java build files look good to me.
Aaron ("AJ") Steers (aaronsteers)
deleted the
feat/ci/add-docker-image-files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
These
Dockerfiledefinitions can be safely merged without impacting other projects or tools. In the long run, this directory should become the authoritative source for image build definition files. Although I included a readme to explain methodology, I do not expect users to call these files directly. They should be wrapped in a tool, probably eitherairbyte-cdk image buildor a nativegradletask.Migrated from here:
airbyte-cdk image buildairbyte-python-cdk#504Related to:
buildImageGradle task to runairbyte-cdk image build#59174I expect after this merges, I will probably refactor the CDK to use the definitions from this directory when building images.
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?