test(source-gong): Old CDK behavior for comparison testing#71787
Closed
devin-ai-integration[bot] wants to merge 14 commits into
Closed
test(source-gong): Old CDK behavior for comparison testing#71787devin-ai-integration[bot] wants to merge 14 commits into
devin-ai-integration[bot] wants to merge 14 commits into
Conversation
- Add SelectiveAuthenticator with OAuth2.0 and APIKey options - Implement refresh_token_updater for Gong's single-use refresh tokens - Add nested credentials structure in connection_specification - Add advanced_auth configuration for platform OAuth flow - Add config migration for backward compatibility with existing API key configs - Bump version from 0.4.14 to 0.5.0 Closes: airbytehq/airbyte-internal-issues#15647 Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
The config_normalization_rules must be nested under the spec section according to the declarative_component_schema.yaml schema, not as a top-level key in the manifest. Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
…-back on already-migrated configs The migration conditions now check that the new format doesn't already exist before running the migration. This prevents the CDK from trying to write back to the config file when the config already has both old and new format fields, which was causing a PermissionError in the Docker test environment. Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
Gong's OAuth API requires client credentials to be sent via Basic Authentication header instead of in the request body. This adds refresh_request_headers with the Authorization header containing base64-encoded client_id:client_secret. Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
…0 with OAuth Basic auth fix Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
…ng OAuth Gong's OAuth token refresh endpoint has unique requirements - it does NOT require client credentials (client_id/client_secret) in the refresh request. Only the refresh_token is needed. Changes: - Updated manifest.yaml to use use_client_credentials_in_refresh: false - Removed the Authorization header workaround (no longer needed) - Updated to CDK prerelease 7.6.3.post4.dev20979241889 which supports this option Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
…n refresh Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
…v21001445621 This CDK version removes the unnecessary use_client_credentials_in_refresh option and keeps only the core fix: excluding client credentials from body when Authorization header is present (for Basic auth). Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
…3 with control message fix Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
…ative OAuth flow Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
…for comparison testing Co-Authored-By: aldo.gonzalez@airbyte.io <aldo.gonzalez@airbyte.io>
Contributor
Author
Original prompt from aldo.gonzalez@airbyte.io |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
Contributor
|
Contributor
|
Contributor
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit 5b535cb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is a test branch created for QA comparison testing of the OAuth 2.0 implementation for source-gong. It uses an older CDK version (
7.6.3.post5.dev21001445621) that does NOT include the control message fix for single-use refresh token persistence.This PR should NOT be merged. It exists solely to create a pre-release that can be pinned to a test workspace for side-by-side comparison with the main PR.
Related:
How
Uses the same OAuth implementation as the main PR but with an older CDK version to test the behavior difference:
Review guide
Do not review for merge - this is a test artifact.
User Impact
None - this is for internal QA testing only.
Can this PR be safely reverted and rolled back?
Link to Devin run: https://app.devin.ai/sessions/bac4e6c3e7684fd1802811a5c8c186a1
Requested by: aldo.gonzalez@airbyte.io