chore: DO NOT MERGE - source-faker with CDK dev (cache pressure test)#75610
chore: DO NOT MERGE - source-faker with CDK dev (cache pressure test)#75610devin-ai-integration[bot] wants to merge 7 commits into
Conversation
…e pressure test) Updates source-faker base image to use source-declarative-manifest dev image 7.13.0.post12.dev23757371941 from CDK PR #970 (cache memory growth without process RSS growth). This is a test branch for validating the memory monitor dual-condition check does NOT trigger on file-backed memory pressure. DO NOT MERGE. Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
|
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
This comment was marked as outdated.
This comment was marked as outdated.
|
/publish-connectors-prerelease
|
|
❔ Pre-release Publish UNKNOWN for |
… dev version (cache pressure test) Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
|
/publish-connectors-prerelease
|
… from /dev/shm to /tmp) Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
This comment was marked as outdated.
This comment was marked as outdated.
…with anon/usage fix) Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
…prerelease) Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
|
/publish-connectors-prerelease
|
|
Looks good in tests |
What
Pins source-faker's
airbyte-cdkdependency to a prerelease dev version that includes cache/file-backed memory pressure testing (from airbyte-python-cdk#970). This will be used to create a dev image of source-faker and test the CDK's memory monitor dual-condition fail-fast via actor pinning.The dev CDK version creates file-backed shared mmap pages on
/tmp(overlay fs) for each consumed record, inflating cgroup memory usage without growing process anonymous RSS (RssAnon). This should not trigger the fail-fast — the monitor should log "pressure likely from file-backed or reclaimable pages" and continue normally.Companion PR: #75609 (memory leak / positive case)
How
airbyte-cdkinpyproject.tomlto==7.13.0.post13.dev23809747805(the dev build from CDK PR Handle more than 100 fields to compute hashid #970).dockerImageTaginmetadata.yamlandversioninpyproject.tomlfrom7.0.3→7.0.4(required by the Connector Version Increment pre-release check).python-connector-base:4.0.2(unchanged from master).Updates since last revision
Reverted the earlier approach of swapping the base image to
source-declarative-manifest. Source-faker is a Python connector (not manifest-only), so the SDM base image was incompatible with theDockerfile.python-connectortemplate. The new approach pins the CDK dependency directly instead.Updated CDK dev version from
7.13.0.post12.dev23757371941→7.13.0.post13.dev23809747805. The new version fixes a SIGBUS crash (exit code 135) by switching the mmap backing store from/dev/shm(tmpfs, ~64 MB limit in Docker) to/tmp(overlay fs, no hard limit). File-backed pages on/tmpstill count toward cgroup memory and go intoRssFile(notRssAnon), preserving the dual-condition test. See CDK PR #970 fix commit.Review guide
airbyte-integrations/connectors/source-faker/pyproject.toml— CDK version pin + version bumpairbyte-integrations/connectors/source-faker/metadata.yaml— version bump only (base image unchanged)airbyte-integrations/connectors/source-faker/poetry.lock— regenerated for new CDK version (large diff due to 6.x → 7.x transitive dependency changes)Human review checklist
airbyte-cdk==7.13.0.post13.dev23809747805is the correct dev version for CDK PR #970pyproject.tomlmatchesdockerImageTaginmetadata.yamlbase_imageinmetadata.yamlis unchanged from masterpoetry.lockdiff is large because CDK jumped from 6.x to 7.x — transitive dependency changes are expectedUser Impact
None — this PR should not be merged. It exists solely to produce a dev image of source-faker for testing the memory fail-fast feature via actor-level version pinning.
Can this PR be safely reverted and rolled back?
Link to Devin session: https://app.devin.ai/sessions/070ecb51ceee4f9189e1c09a83ba31cb