Skip to content

chore(source-harvest): bump SDM base image for memory monitor (CDK PR #962)#75944

Closed
devin-ai-integration[bot] wants to merge 2 commits into
masterfrom
devin/1774998580-sdm-dev-harvest
Closed

chore(source-harvest): bump SDM base image for memory monitor (CDK PR #962)#75944
devin-ai-integration[bot] wants to merge 2 commits into
masterfrom
devin/1774998580-sdm-dev-harvest

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Mar 31, 2026 •
edited
Loading

What

Updates source-harvest to use the dev build of source-declarative-manifest from airbyte-python-cdk#962, which introduces the dual-condition memory monitor with fail-fast shutdown on memory threshold.

How

Review guide

  1. airbyte-integrations/connectors/source-harvest/metadata.yaml — base image swap and version bump
  2. docs/integrations/sources/harvest.md — changelog entry

Human review checklist

User Impact

Connectors built from this PR will use the dev SDM image containing the new memory monitor. Low-usage certified connector selected to minimize blast radius.

Can this PR be safely reverted and rolled back?

  • YES 💚

Link to Devin session: https://app.devin.ai/sessions/070ecb51ceee4f9189e1c09a83ba31cb

@devin-ai-integration @pnilan
chore: DO NOT MERGE - source-harvest with CDK dev image (memory monit…
702ad73 
…or test)

Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

devin-ai-integration Bot commented Mar 31, 2026

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@octavia-bot octavia-bot Bot marked this pull request as draft March 31, 2026 23:15
@octavia-bot
Copy link
Copy Markdown
Contributor

octavia-bot Bot commented Mar 31, 2026

Note

📝 PR Converted to Draft

More info...

Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy.

As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page.

To skip draft status in future PRs, please include [ready] in your PR title or add the skip-draft-status label when creating your PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2026

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • 🛠️ Quick Fixes
    • /format-fix - Fixes most formatting issues.
    • /bump-version - Bumps connector versions, scraping changelog description from the PR title.
      • Bump types: patch (default), minor, major, major_rc, rc, promote.
      • The rc type is a smart default: applies minor_rc if stable, or bumps the RC number if already RC.
      • The promote type strips the RC suffix to finalize a release.
      • Example: /bump-version type=rc or /bump-version type=minor
    • /bump-progressive-rollout-version - Alias for /bump-version type=rc. Bumps with an RC suffix and enables progressive rollout.
  • ❇️ AI Testing and Review (internal link: AI-SDLC Docs):
    • /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
    • /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
    • /ai-review - AI-powered PR review for connector safety and quality gates.
  • 🚀 Connector Releases:
    • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
  • ☕️ JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
  • 🐍 Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
  • ⚙️ Admin commands:
    • /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
      Example: /force-merge reason="CI is flaky, tests pass locally"
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@devin-ai-integration @pnilan
chore(source-harvest): add changelog entry for 1.2.33
5d987db 
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2026 •
edited
Loading

source-harvest Connector Test Results

187 tests   186 ✅  3m 55s ⏱️
  2 suites    1 💤
  2 files      0 ❌

Results for commit 5d987db.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2026

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-iwvywhwrf-airbyte-growth.vercel.app

Built with commit 5d987db.
This pull request is being automatically deployed with vercel-action

@devin-ai-integration devin-ai-integration Bot changed the title chore: DO NOT MERGE - source-harvest with CDK dev image (memory monitor test) chore(source-harvest): bump SDM base image for memory monitor (CDK PR #962) Mar 31, 2026
@pnilan Patrick Nilan (pnilan) marked this pull request as ready for review April 1, 2026 00:34
@pnilan
Copy link
Copy Markdown
Contributor

Patrick Nilan (pnilan) commented Apr 1, 2026 •
edited by octavia-bot Bot
Loading

/ai-prove-fix

AI Prove Fix Started

Running readiness checks and testing against customer connections.
View workflow run
🔍 AI Prove Fix session starting... Running readiness checks and testing against customer connections. View playbook

✅ Devin AI session created successfully!

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

devin-ai-integration Bot commented Apr 1, 2026 •
edited
Loading

Fix Validation Evidence

Outcome: Fix/Feature Proven Successfully

Evidence Summary

Regression tests completed successfully for source-harvest v1.2.33 (base image bump for memory monitor, CDK PR #962). The comparison regression test ran the connector against both the current published version and the pre-release version in an isolated environment, confirming no regressions introduced by the base image change. PR CI also passed (186/187 tests passed, 1 skipped). Since this is an infrastructure-only change (base image swap with no connector logic modifications), regression test success provides strong proving evidence.

Live connection testing was not performed: pre-release publish was blocked by a progressive rollout configuration issue, and live testing approval was declined (not needed given regression evidence strength for this type of change).

Next Steps
  1. This PR appears ready for review and merge.
  2. For broader validation before release, consider running /ai-canary-prerelease to test on additional connections.
  3. The daily_hands_free_triage automation will monitor the release rollout after merge.
  4. Note: The pre-release publish failure (enableProgressiveRollout flag requires RC version suffix) may warrant investigation for the publish workflow to support preview versions correctly.
Connector & PR Details

Connector: source-harvest
PR: #75944
Pre-release Version Tested: 1.2.33-preview.5d987db
Change: Bump SDM base image from 7.13.0.post6.dev23497311155 to 7.13.0.post13.dev23823332086
Session: https://app.devin.ai/sessions/2a953a38e6e24c32b4c7772d0a99405b

Evidence Plan

Proving Criteria

A sync completes successfully with the new base image, demonstrating no regression from the memory monitor infrastructure changes. Since this is a base image bump (not a logic change), successful sync = no regression introduced.

Disproving Criteria

  • A sync that previously succeeded now fails after applying the new base image
  • Memory-related errors or OOM crashes appear that weren't present before
  • New errors in connector logs attributable to the base image change

Cases Attempted

# Case Type Result
1 Regression tests (comparison) Isolated PASSED
2 PR CI connector tests Isolated 186/187 passed (1 skipped)
3 Live connection test Live Skipped (pre-release publish blocker + approval declined)
Pre-flight Checks
  • Viability: Fix addresses the reported issue — base image bump for memory monitor (CDK PR editing a oneOf config doesn't show the selected sub-schema  #962). Only metadata.yaml (base image + version) and changelog are changed. No connector logic modifications.
  • Safety: No malicious code or dangerous patterns. Changes are limited to image reference and version metadata.
  • Breaking Change: No breaking changes detected. No schema, spec, stream, state, or PK/cursor changes. Only infrastructure-level base image swap.
  • Reversibility: Can be safely reverted — version bump follows semver (patch), no state/config format changes. Previous version would continue to work after downgrade.
Detailed Evidence Log

Regression Tests (Phase 1)

  • Workflow: airbyte-ops-mcp/actions/runs/23826506105
  • Job: Regression Test: 'source-harvest'
  • Started: 2026-04-01T00:51:25Z
  • Completed: 2026-04-01T01:09:24Z
  • Duration: approximately 18 minutes
  • Conclusion: SUCCESS
  • Test type: Comparison (control version vs. target pre-release version)

PR CI Tests

  • Result: 186/187 tests passed, 1 skipped, 0 failed
  • Duration: 3m 55s
  • Commit: 5d987db

Pre-release Publish Attempts

Attempt Workflow Result Error
1 (automated) 23826206202 FAILED enableProgressiveRollout requires RC suffix
2 (MCP) 23826558333 FAILED Same error

Live Testing Approval

Devin session

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026 •
edited
Loading

Pre-release Connector Publish Started

Publishing pre-release build for connector source-harvest.
PR: #75944

Pre-release versions will be tagged as {version}-preview.5d987db
and are available for version pinning via the scoped_configuration API.

View workflow run
❌ Pre-release Publish FAILED for source-harvest.

@pnilan
Copy link
Copy Markdown
Contributor

Patrick Nilan (pnilan) commented Apr 1, 2026

closing -- currently a rc version

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026 •
edited
Loading

Pre-release Connector Publish Started

Publishing pre-release build for connector source-harvest.
PR: #75944

Pre-release versions will be tagged as {version}-preview.5d987db
and are available for version pinning via the scoped_configuration API.

View workflow run
❌ Pre-release Publish FAILED for source-harvest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pnilan Patrick Nilan (pnilan) Awaiting requested review from pnilan

Assignees

No one assigned

Labels

connectors/source/harvest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pnilan @octavia-squidington-iii