fix(source-mixpanel): replace deprecated MessageRepresentationAirbyteTracedErrors with AirbyteTracedException#76039
Conversation
…TracedErrors with AirbyteTracedException Replace import and usage of the removed MessageRepresentationAirbyteTracedErrors class with AirbyteTracedException from airbyte_cdk.utils.traced_exception in test file. The MessageRepresentationAirbyteTracedErrors class was removed in CDK PR #927 (airbyte-python-cdk v7.10.2) without a backward-compatible alias, causing ImportError. Resolves airbytehq/oncall#11850 Co-Authored-By: bot_apk <apk@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Co-Authored-By: bot_apk <apk@cognition.ai>
|
Co-Authored-By: bot_apk <apk@cognition.ai>
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit cfd4a73. |
|
/ai-prove-fix
|
Patrick Nilan (pnilan)
left a comment
There was a problem hiding this comment.
Pending ai-prove-fix
Fix Validation EvidenceOutcome: Fix Validated — No Regressions Detected ✅ Session: Devin Session
Evidence SummaryRegression tests (comparison mode) ran
The This is the expected outcome because this PR only modifies Additional Validation
RecommendationThis PR is safe to merge. The fix correctly replaces a removed import in test code. Regression tests confirm identical runtime behavior between control and target versions. Pre-flight Checks
Evidence PlanNature of the ChangeThis PR is a test-only fix — it replaces a deprecated import ( Proving Criteria
Disproving Criteria
|
|
|
↪️ Triggering Reason: Prove-fix validated, CI all green — advancing to review stage. Session: https://app.devin.ai/sessions/944109c31676472da2e61c4602224cad |
Reviewing PR for connector safety and quality.
|
AI PR Review ReportReview Action: NO ACTION (NOT ELIGIBLE)
📋 PR Details & EligibilityConnector & PR InfoConnector(s): Auto-Approve EligibilityEligible: No Review Action DetailsNO ACTION (NOT ELIGIBLE) — All gates pass but PR is not eligible for auto-approval because it contains functional test code changes beyond docs/spec/deps. No PR review submitted. Human review required.
🔍 Gate Evaluation DetailsGate-by-Gate Analysis
Detailed File AnalysisChanged files (4):
📚 Evidence ConsultedEvidence
|
…TracedErrors with AirbyteTracedException (airbytehq#76039) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: bot_apk <apk@cognition.ai>
What
Replace the removed
MessageRepresentationAirbyteTracedErrorsclass withAirbyteTracedExceptionin source-mixpanel unit tests.MessageRepresentationAirbyteTracedErrorswas removed fromairbyte_cdk.sources.streams.http.http_clientin CDK PR #927 (v7.10.2) without a backward-compatible alias, causingImportErrorwhen running the test suite on newer CDK versions.Resolves https://github.com/airbytehq/oncall/issues/11850:
How
airbyte_cdk.sources.streams.http.http_client.MessageRepresentationAirbyteTracedErrorstoairbyte_cdk.utils.traced_exception.AirbyteTracedExceptionexceptclause intest_handle_time_zone_mismatchto catchAirbyteTracedExceptionairbyte_cdkblock)Review guide
unit_tests/test_streams.py— import replacement + catch clause updatemetadata.yaml/pyproject.toml— version bumpdocs/integrations/sources/mixpanel.md— changelog entryKey consideration:
MessageRepresentationAirbyteTracedErrorswas a subclass ofAirbyteTracedException. Catching the base class is now slightly broader. In this test (test_handle_time_zone_mismatch), the assertion onairbyte_error.messagestill validates the specific error, so a false-positive pass is unlikely. Verify this is acceptable.User Impact
No user-facing behavior change. Fixes broken test suite on CDK >= v7.10.2.
Can this PR be safely reverted and rolled back?
Link to Devin session: https://app.devin.ai/sessions/83cdd5ae8ab140fa9b4c072d44e9163a