fix(source-postgres): Don't store INFINITY in Airbyte numeric types#78305
fix(source-postgres): Don't store INFINITY in Airbyte numeric types#78305Matt Bayley (mwbayley) wants to merge 2 commits into
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Detected
|
|
2bbff3b to
890eb60
Compare
890eb60 to
19b5d54
Compare
There was a problem hiding this comment.
Changes to this file make no modifications to behavior. I had originally tried to not modify this file from the previous connector, but the streamed array lookups were making my eyes bleed.
|
The plan is to pick up the CDK changes from #78091 as soon as it is merged, and then use this PR to release 3.8.0. |
|
Deploy preview for airbyte-docs ready!
Deployed with vercel-action |
| DoubleFieldType -> Jsons.numberNode(input.asDouble()) | ||
| // Narrow numeric nodes to the right precision so the codec's | ||
| // IEEE-754 roundtrip check passes (Debezium emits float4 values as | ||
| // DoubleNode in JSON). For non-numeric forms — e.g. TextNode("Infinity") |
There was a problem hiding this comment.
Does the fact that java Double type supports +/- infinity value matte here?
"Infinity" is a string representing the value of 7FF0000000000000
"-Infinity" is FFF0000000000000.
Is it incorrect to expect these values?
the value is also in IEEE-754
|
↪️ Escalated to #human-in-the-loop per Hands-Free AI Triage Project triage next step. Reason: Draft source-postgres INFINITY PR is waiting on related CDK/connector dependency work and has rollout-gate failures; keep blocked pending dependency resolution. |
Fix cases where "INFINITY" is passed as a numeric value to destinations
Can this PR be safely reverted and rolled back?
Important
Active progressive rollout warning for source-postgres.