fix(source-amazon-seller-partner): classify marketplace errors#78309
Draft
devin-ai-integration[bot] wants to merge 2 commits into
Draft
fix(source-amazon-seller-partner): classify marketplace errors#78309devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Contributor
|
Deploy preview for airbyte-docs ready!
Deployed with vercel-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/16457
Related to https://github.com/airbytehq/oncall/issues/12673
Report creation failures from Amazon SP-API for merchant accounts that are not registered in the selected marketplace were falling through to the default HTTP 400 handler, producing a generic
system_error.How
HttpResponseFilterforInvalidInputreport-creation responses whose message indicates the merchant account is not registered in the marketplace.config_errorwith the deterministic user-facing messageMerchant account is not registered in the selected marketplace.source-amazon-seller-partnerfrom5.7.6to5.7.7with a changelog entry.Review guide
airbyte-integrations/connectors/source-amazon-seller-partner/manifest.yamlairbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/integration/test_report_based_streams.pyairbyte-integrations/connectors/source-amazon-seller-partner/metadata.yamldocs/integrations/sources/amazon-seller-partner.mdUser Impact
Users with a marketplace registration mismatch now receive a
config_errorthat names the specific configuration issue instead of a genericsystem_errorHTTP 400 message. This can stop retries for this specific non-retryable configuration problem.Can this PR be safely reverted and rolled back?
Testing
cd airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests && poetry run pytest integration/test_report_based_streams.py::TestFullRefresh::test_given_marketplace_registration_error_when_read_then_config_errorpre-commit run ruff-format --files airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/integration/test_report_based_streams.pyDevin session