Fix buffer overflow in hex_decode.cc

airween · airween · commit 352b7056646e · 2026-04-28T15:51:22.000+02:00
diff --git a/src/actions/transformations/hex_decode.cc b/src/actions/transformations/hex_decode.cc
@@ -28,7 +28,7 @@ static inline int inplace(std::string &value) {
     auto d = reinterpret_cast<unsigned char *>(value.data());
     const auto *data = d;
 
-    for (int i = 0; i <= len - 2; i += 2) {
+    for (std::string::size_type i = 0; i + 1 < len; i += 2) {
         *d++ = utils::string::x2c(&data[i]);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ static inline int inplace(std::string &value) {`
`28`	`28`	`auto d = reinterpret_cast<unsigned char *>(value.data());`
`29`	`29`	`const auto *data = d;`
`30`	`30`
`31`		`- for (int i = 0; i <= len - 2; i += 2) {`
	`31`	`+ for (std::string::size_type i = 0; i + 1 < len; i += 2) {`
`32`	`32`	`*d++ = utils::string::x2c(&data[i]);`
`33`	`33`	`}`
`34`	`34`