feat(upgradepipeline): wip

Author: ndk

controllers/upgradepipelinestep_controller.go

@@ -162,11 +162,16 @@ func (r *UpgradePipelineStepController) lookupStep(ctx context.Context, cr *v1al
 
 func (*UpgradePipelineStepController) applyStatus(cr *v1alpha1.UpgradePipelineStep, step upgradepipeline.StepOut) {
 	cr.Status.ID = step.StepId
-	cr.Status.LastValidation = &v1alpha1.UpgradePipelineStepLastValidationStatus{
+	lastValidation := &v1alpha1.UpgradePipelineStepLastValidationStatus{
 		Comment:         step.LastValidation.Comment,
 		ValidatedAt:     NilIfZero(metav1.NewTime(step.LastValidation.ValidatedAt)),
 		ValidatedByUser: step.LastValidation.ValidatedByUser,
 	}
+	if lastValidation.Comment == "" && lastValidation.ValidatedAt == nil && lastValidation.ValidatedByUser == "" {
+		cr.Status.LastValidation = nil
+	} else {
+		cr.Status.LastValidation = lastValidation
+	}
 	meta.SetStatusCondition(&cr.Status.Conditions, getRunningCondition(metav1.ConditionTrue, "CheckRunning", "Instance is running on Aiven side"))
 	metav1.SetMetaDataAnnotation(&cr.ObjectMeta, instanceIsRunningAnnotation, "true")
 }

controllers/upgradepipelinestep_controller_test.go

@@ -105,6 +105,7 @@ func TestUpgradePipelineStepReconciler(t *testing.T) {
 		require.NoError(t, r.Get(t.Context(), types.NamespacedName{Name: step.Name, Namespace: step.Namespace}, got))
 		require.Contains(t, got.Finalizers, instanceDeletionFinalizer)
 		require.Equal(t, "step-create", got.Status.ID)
+		require.Nil(t, got.Status.LastValidation)
 		require.Equal(t, "1", got.Annotations[processedGenerationAnnotation])
 		require.Equal(t, "true", got.Annotations[instanceIsRunningAnnotation])
 	})