fix(controllers): wait for connection secret before ready#1181
Open
ndk wants to merge 2 commits into
Open
Conversation
ndk
force-pushed
the
nex-2511-secret-ready
branch
from
c5cae80 to
ed85a40
Compare
Contributor
Author
|
/test |
Contributor
❌ Acceptance Tests FailedWorkflow: View Details |
ndk
force-pushed
the
nex-2511-secret-ready
branch
from
14f15f6 to
dbe34d8
Compare
byashimov
reviewed
Jun 3, 2026
| } | ||
|
|
||
| func (i *instanceReconcilerHelper) resourceNeedsConnectionSecretSync(ctx context.Context, o v1alpha1.AivenManagedObject) bool { | ||
| if GetIsRunningAnnotation(o) == "false" { |
Contributor
There was a problem hiding this comment.
I would make a helper that just would return a real boolean.
| } | ||
|
|
||
| ref := metav1.GetControllerOf(secret) | ||
| return ref == nil || o.GetUID() == "" || ref.UID != o.GetUID() |
Contributor
There was a problem hiding this comment.
Please add a bit of explanation what happens here.
ndk
force-pushed
the
nex-2511-secret-ready
branch
from
dbe34d8 to
3f35fb4
Compare
Contributor
Author
|
/test |
Contributor
❌ Acceptance Tests FailedWorkflow: View Details |
Contributor
Author
|
/test |
Contributor
❌ Acceptance Tests FailedWorkflow: View Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: NEX-2511
Fix service readiness so a resource isn't reported as ready until its connection Secret has been successfully published.