set default minVotes param in search segments to -Infinity#631
Merged
Conversation
it would be very nice to assume our database would be consistent with the intended behaviour, but alas it is not, and it is still possible to double-downvote a segment if the server is sufficiently laggy. the minVotes param defaulting to -3 was a source of confusion in VIPs multiple times already, where they thought a segment had completely disappeared from the db, but it was simply excluded from the results due to being below the default vote threshold to return. search segments is expected to return all submitted segments on a video if no parameters are set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it would be very nice to assume our database would be consistent with the intended behaviour, but alas it is not, and it is still possible to double-downvote a segment if the server is sufficiently laggy.
the minVotes param defaulting to -3 was a source of confusion in VIPs multiple times already, where they thought a segment had completely disappeared from the db, but it was simply excluded from the results due to being below the default vote threshold to return. search segments is expected to return all submitted segments on a video if no parameters are set.