From 12c31ddc48fea4f93f21e3cc899e5deda4ae4881 Mon Sep 17 00:00:00 2001 From: Ajeet Chaulagain Date: Sat, 28 Mar 2026 07:58:19 +1100 Subject: [PATCH] Refactor: code cleanup and consistency improvements - Fix Heading4 using styled.h3 instead of styled.h4 (wrong semantic element) - Fix switch fallthrough: add missing break after case 'h4' in Heading component - Remove redundant iconName guard in Icon.tsx (double-checked after early return) - Remove unintended export of internal Container styled component in HeroBlank.tsx - Replace social-media-icons/styles barrel export with InfoCallToAction export in components/index.ts - Standardize sibling component imports to use relative paths in MarkdownRenderer and GetInTouchSection Co-Authored-By: Claude Sonnet 4.6 --- src/components/get-in-touch-section/GetInTouchSection.tsx | 4 ++-- src/components/heading/Heading.tsx | 3 ++- src/components/hero-blank/HeroBlank.tsx | 2 +- src/components/icon/Icon.tsx | 2 +- src/components/index.ts | 2 +- src/components/markdown-renderer/MarkdownRenderer.tsx | 2 +- 6 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/components/get-in-touch-section/GetInTouchSection.tsx b/src/components/get-in-touch-section/GetInTouchSection.tsx index b786687b..ad409a54 100644 --- a/src/components/get-in-touch-section/GetInTouchSection.tsx +++ b/src/components/get-in-touch-section/GetInTouchSection.tsx @@ -2,8 +2,8 @@ import React from 'react'; import { Paragraph } from '../paragraph/Paragraph'; import { socialMediaLinks } from '../social-media-icons/socialMediaLinks'; import { Container, SocialLinksList, SocialLinkItem } from './styles'; -import { Heading } from 'components/heading/Heading'; -import { ButtonLink } from 'components/button-link'; +import { Heading } from '../heading/Heading'; +import { ButtonLink } from '../button-link'; export const GetInTouchSection = () => { return ( diff --git a/src/components/heading/Heading.tsx b/src/components/heading/Heading.tsx index e041cbba..29c80e05 100644 --- a/src/components/heading/Heading.tsx +++ b/src/components/heading/Heading.tsx @@ -74,7 +74,7 @@ const Heading3 = styled.h3<{ size?: HeadingFontSize; type?: FontType }>` `}; `; -const Heading4 = styled.h3<{ size?: HeadingFontSize; type?: FontType }>` +const Heading4 = styled.h4<{ size?: HeadingFontSize; type?: FontType }>` font-size: ${({ size, theme: { headingFontSizes } }) => size ? headingFontSizes[size] : headingFontSizes.medium}; @@ -95,6 +95,7 @@ export const Heading = ({ level, children, ...rest }: HeadingProps) => { break; case 'h4': HeadingComponent = Heading4; + break; default: HeadingComponent = Heading1; break; diff --git a/src/components/hero-blank/HeroBlank.tsx b/src/components/hero-blank/HeroBlank.tsx index 091e8b0c..247bb415 100644 --- a/src/components/hero-blank/HeroBlank.tsx +++ b/src/components/hero-blank/HeroBlank.tsx @@ -4,7 +4,7 @@ import styled from 'styled-components'; import breakpoint from 'styled-components-breakpoint'; import { py } from 'styled-components-spacing'; -export const Container = styled.div` +const Container = styled.div` width: 100%; `; diff --git a/src/components/icon/Icon.tsx b/src/components/icon/Icon.tsx index 70d24c0a..76882ba4 100644 --- a/src/components/icon/Icon.tsx +++ b/src/components/icon/Icon.tsx @@ -36,6 +36,6 @@ export const Icon = ({ iconName }: { iconName: IconName }) => { if (!iconName) { return null; } - const IconComponent = iconName && IconMap[iconName]; + const IconComponent = IconMap[iconName]; return ; }; diff --git a/src/components/index.ts b/src/components/index.ts index 4ea29cfb..2e3ccfd2 100644 --- a/src/components/index.ts +++ b/src/components/index.ts @@ -17,7 +17,7 @@ export * from './project-card'; export * from './button-link'; export * from './paragraph/Paragraph'; export * from './social-media-icons/SocialMediaIcons'; -export * from './social-media-icons/styles'; +export * from './info-call-to-action/InfoCallToAction'; export * from './hero-blank/HeroBlank'; export * from './tag/Tag'; export * from './comments/Comments'; diff --git a/src/components/markdown-renderer/MarkdownRenderer.tsx b/src/components/markdown-renderer/MarkdownRenderer.tsx index c87595ed..1f0dcbd6 100644 --- a/src/components/markdown-renderer/MarkdownRenderer.tsx +++ b/src/components/markdown-renderer/MarkdownRenderer.tsx @@ -15,7 +15,7 @@ import { StyledParagraph, } from './styles'; import { slugify } from './slugify'; -import { InfoCallToAction } from 'components/info-call-to-action/InfoCallToAction'; +import { InfoCallToAction } from '../info-call-to-action/InfoCallToAction'; type MarkdownRendererProps = { children: React.ReactNode;