Skip to content

Feat: Make matplotlib optional#366

Merged
ajhynes7 merged 10 commits into
masterfrom
365-wish-make-matplotlib-an-optional-requirement
Apr 17, 2025
Merged

Feat: Make matplotlib optional#366
ajhynes7 merged 10 commits into
masterfrom
365-wish-make-matplotlib-an-optional-requirement

Conversation

@ajhynes7
Copy link
Copy Markdown
Owner

No description provided.

@ajhynes7 ajhynes7 linked an issue Apr 13, 2025 that may be closed by this pull request
@ajhynes7 ajhynes7 requested a review from Copilot April 13, 2025 23:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/skspatial/plotting.py:11

  • Add tests to simulate the absence of Matplotlib, ensuring that the ImportError with the correct message is raised when plotting functions are called.
except ImportError as error:

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (c5cb146) to head (67d35f0).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   99.80%   99.80%   -0.01%     
==========================================
  Files          21       21              
  Lines        1041     1033       -8     
==========================================
- Hits         1039     1031       -8     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

@ajhynes7 ajhynes7 merged commit ac7bc72 into master Apr 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wish: Make matplotlib an optional requirement

2 participants