Skip to content

Commit 01a0430

Browse files
Ajit Pratap Singhclaude
authored andcommitted
docs: fix review issues — stale LSP footer, missing ClickHouse in dialects table, perf stat, PRAGMA contradiction
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 101f5c5 commit 01a0430

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

docs/GETTING_STARTED.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ gosqlx lsp --log /tmp/lsp.log
453453
### Advanced Topics:
454454
- **Low-Level API** - For performance-critical applications (>100K queries/sec)
455455
- **Object Pooling** - Manual resource management for fine-grained control
456-
- **Multi-Dialect Support** - PostgreSQL, MySQL, SQL Server, Oracle, SQLite
456+
- **Multi-Dialect Support** - PostgreSQL, MySQL, SQL Server, Oracle, SQLite, ClickHouse
457457
- **Unicode Support** - Full international character support
458458
- **SQL Compatibility** - See [SQL Compatibility](/docs/sql-compatibility) for dialect matrix
459459

docs/LSP_GUIDE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -445,5 +445,5 @@ tail -f /tmp/gosqlx-lsp.log | grep -E "Initialize|Document|Diagnostic"
445445

446446
---
447447

448-
**Last Updated**: December 2025
449-
**Version**: v1.6.0
448+
**Last Updated**: 2026-03-20
449+
**Version**: v1.13.0

docs/SQL_COMPATIBILITY.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -548,6 +548,7 @@ GoSQLX v1.8.0 introduces a first-class dialect mode engine that threads the SQL
548548
| **Oracle** | `"oracle"` | Oracle keywords | DUAL table, basic PL/SQL keywords | ⚠️ Keywords + basic parsing |
549549
| **SQLite** | `"sqlite"` | SQLite keywords | Flexible typing, simplified syntax | ⚠️ Keywords + basic parsing |
550550
| **Snowflake** | `"snowflake"` | Snowflake keywords | Stage operations, VARIANT type | ⚠️ Keyword detection only |
551+
| **ClickHouse** | `"clickhouse"` | ClickHouse keywords | PREWHERE, FINAL, GLOBAL IN/NOT IN, MergeTree keywords | ✅ v1.13.0 |
551552

552553
### Usage
553554

@@ -739,7 +740,7 @@ gosqlx format --dialect mysql query.sql
739740
- **OFFSET-FETCH** - Standard row limiting
740741
- **Multi-dialect basic syntax**
741742
- **Unicode and international text**
742-
- **High-performance scenarios** (1.25M ops/sec peak)
743+
- **High-performance scenarios** (1.38M+ ops/sec, 1.5M peak)
743744

744745
### Suitable with Considerations
745746

@@ -756,7 +757,6 @@ gosqlx format --dialect mysql query.sql
756757
- **Full XML function support**
757758
- **Row pattern recognition (MATCH_RECOGNIZE)**
758759
- **Complete temporal table support**
759-
- **SQLite PRAGMA statements** (keywords reserved)
760760
- **Advanced array operations**
761761

762762
## Recommendations

0 commit comments

Comments
 (0)