Skip to content

Commit 466c3e4

Browse files
Ajit Pratap Singhclaude
authored andcommitted
fix: trim whitespace in user binary path and document VSCE_PAT scope
- Trim whitespace from executablePath setting to handle accidental spaces - Add VSCE_PAT documentation comment to workflow with setup instructions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 15b01ea commit 466c3e4

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

.github/workflows/vscode-publish.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
11
name: Publish VSCode Extension
2+
# Publishes platform-specific VSIXs to the VS Code Marketplace on tag push.
3+
# Runs in parallel with release.yml (GoReleaser).
4+
#
5+
# Required secret:
6+
# VSCE_PAT - Azure DevOps Personal Access Token with "Marketplace (Manage)" scope.
7+
# Create at: https://dev.azure.com → User Settings → Personal Access Tokens
8+
# Scope: "Marketplace (Manage)", Organization: "All accessible organizations"
29

310
on:
411
push:

vscode-extension/src/utils/binaryResolver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export interface BinaryResolverDeps {
3434
*/
3535
export async function getBinaryPath(deps: BinaryResolverDeps): Promise<string> {
3636
// 1. Explicit user setting (non-empty means user override)
37-
const userPath = deps.getConfig('executablePath', '');
37+
const userPath = deps.getConfig('executablePath', '')?.trim();
3838
if (userPath) {
3939
return userPath;
4040
}

0 commit comments

Comments
 (0)