fix: resolve critical nil pointer dereferences in ALTER parser (#101)

* fix: resolve critical nil pointer dereferences in ALTER parser

Fixes three critical nil pointer dereference bugs discovered during
comprehensive error recovery testing:

1. ALTER TABLE DROP COLUMN - missing column name check (line 61)
2. ALTER TABLE DROP CONSTRAINT - missing constraint name check (line 72)
3. ALTER TABLE ALTER COLUMN - missing column name check (line 109)

All three cases now properly check if parseIdent() returns nil before
accessing the Name field, returning appropriate error messages instead
of crashing.

These bugs would have caused production crashes when parsing invalid
ALTER statements missing required identifier tokens.

Fixes issues discovered in TEST-013: Parser Error Recovery Tests

* fix: add nil checks for RENAME COLUMN operations

Addresses code review feedback by adding nil checks for both
the old column name and new column name in RENAME COLUMN operations.

This completes the nil pointer dereference fixes for ALTER TABLE
statements by handling all parseIdent() calls that could return nil.

Changes:
- Added nil check after parseIdent() for old column name (line 91)
- Added nil check after parseIdent() for new column name (line 100)
- Returns descriptive error messages for missing identifiers

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Ajit Pratap Singh <ajitpratapsingh@Ajits-Mac-mini.local>
Co-authored-by: Claude <noreply@anthropic.com>

Author: 3 people

pkg/sql/parser/alter.go

@@ -58,6 +58,9 @@ func (p *Parser) parseAlterTableStatement(stmt *ast.AlterStatement) (*ast.AlterS
 			op.Type = ast.DropColumn
 			// Convert ast.Identifier to ast.Ident
 			ident := p.parseIdent()
+			if ident == nil {
+				return nil, p.expectedError("column name")
+			}
 			op.ColumnName = &ast.Ident{Name: ident.Name}
 			if p.matchToken(token.CASCADE) {
 				op.CascadeDrops = true
@@ -66,6 +69,9 @@ func (p *Parser) parseAlterTableStatement(stmt *ast.AlterStatement) (*ast.AlterS
 			op.Type = ast.DropConstraint
 			// Convert ast.Identifier to ast.Ident
 			ident := p.parseIdent()
+			if ident == nil {
+				return nil, p.expectedError("constraint name")
+			}
 			op.ConstraintName = &ast.Ident{Name: ident.Name}
 			if p.matchToken(token.CASCADE) {
 				op.CascadeDrops = true
@@ -82,12 +88,18 @@ func (p *Parser) parseAlterTableStatement(stmt *ast.AlterStatement) (*ast.AlterS
 			op.Type = ast.RenameColumn
 			// Convert ast.Identifier to ast.Ident
 			ident := p.parseIdent()
+			if ident == nil {
+				return nil, p.expectedError("column name")
+			}
 			op.ColumnName = &ast.Ident{Name: ident.Name}
 			if !p.matchToken(token.TO) {
 				return nil, p.expectedError("TO")
 			}
 			// Convert ast.Identifier to ast.Ident
 			newIdent := p.parseIdent()
+			if newIdent == nil {
+				return nil, p.expectedError("new column name")
+			}
 			op.NewColumnName = &ast.Ident{Name: newIdent.Name}
 		} else {
 			return nil, p.expectedError("TO or COLUMN")
@@ -100,6 +112,9 @@ func (p *Parser) parseAlterTableStatement(stmt *ast.AlterStatement) (*ast.AlterS
 		op.Type = ast.AlterColumn
 		// Convert ast.Identifier to ast.Ident
 		ident := p.parseIdent()
+		if ident == nil {
+			return nil, p.expectedError("column name")
+		}
 		op.ColumnName = &ast.Ident{Name: ident.Name}
 		colDef, err := p.parseColumnDef()
 		if err != nil {