fix(website): enable Next.js static export for GitHub Pages#393
fix(website): enable Next.js static export for GitHub Pages#393ajitpratap0 wants to merge 1 commit into
Conversation
- Add output: 'export' and images.unoptimized for static site generation - Update workflow artifact path from dist to out (Next.js export output dir) - Restore CNAME file to preserve gosqlx.dev custom domain on deploy Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Claude finished @ajitpratap0's task —— View job PR Review: Next.js Static Export Configuration ✅I've completed my review of this pull request that fixes the website deployment workflow after the Astro → Next.js migration. Review Tasks:
🔍 Overall AssessmentThis PR correctly addresses the deployment issue by properly configuring Next.js static export. The changes are minimal, focused, and appropriate for GitHub Pages hosting. ✅ What's Working Well1. Next.js Configuration (
2. Workflow Update (
3. Custom Domain (
🛡️ Security Analysis
⚡ Performance Considerations
🧪 Test Coverage
🔧 Code Quality
📋 Minor Suggestions
🎯 ConclusionThis is a solid fix that properly addresses the deployment failure. The changes are:
Recommendation: ✅ Approve and merge The PR successfully resolves the deployment issue while maintaining all existing functionality. The static export configuration is standard and appropriate for GitHub Pages hosting. |
|
Closing — moving to Vercel deployment instead of GitHub Pages static export. Next.js doesn't need output: 'export' on Vercel. |
Summary
output: 'export'andimages: { unoptimized: true }tonext.config.tssonext buildgenerates static HTML intowebsite/out/website.ymlartifact path fromwebsite/dist(Astro) →website/out(Next.js)website/public/CNAMEwithgosqlx.devto preserve the custom domain on each deployWhy
The deploy workflow was failing with
tar: website/dist: Cannot open: No such file or directoryafter migrating from Astro to Next.js in #390.🤖 Generated with Claude Code