feat: v1.15.0 dialect gaps — Oracle, ClickHouse 100%, WINDOW, AST roundtrip

[ajitpratap0]

Summary

Close the dialect gaps and harden roundtrip fidelity for v1.15.0. Theme: "Close the dialect gaps, harden roundtrip fidelity."

Oracle (80% → ~95% compat)

• ROWNUM/ROWID/LEVEL/SYSDATE pseudo-columns now parse as expressions with implicit aliasing (SELECT ROWNUM rn)
• CONNECT BY / IS NULL no longer misinterpreted as CTE
• PIVOT/UNPIVOT IN list supports AS aliases (Oracle syntax: 'North' AS north)
• Backslash in string literals treated as literal for non-MySQL/PG dialects (fixes REGEXP_LIKE patterns)
• Dedicated oracle_test.go with 14 regression tests

ClickHouse (69/83 → 83/83 QA — 100%)

• ARRAY JOIN / LEFT ARRAY JOIN — new ArrayJoinClause AST node with SQL() serialization
• Named WINDOW clause (SQL:2003) — WINDOW w AS (PARTITION BY a ORDER BY b)
• Scalar CTE — WITH <expr> AS <name> (ClickHouse extension)
• CREATE MATERIALIZED VIEW with ENGINE/TO clauses
• CREATE TABLE AS <source> ENGINE = ... (clone-table syntax)
• SAMPLE with numeric args (0.1, N/D fractions, OFFSET) — no longer consumed as table alias
• LIMIT offset, count syntax (MySQL-style comma) enabled for ClickHouse
• SETTINGS clause no longer consumed as table alias

SQL Server

• OUTPUT clause in INSERT parsed regardless of dialect (dialect-agnostic)

AST Roundtrip

• SQL() methods for PragmaStatement, ShowStatement, DescribeStatement, ReplaceStatement

Build & Infra

• Fix cbinding CGO_ENABLED=0 conflict: dedicated test:cbinding task, test:race excludes cbinding

Test plan

• go test -race -timeout 60s ./pkg/... — all 36 packages pass, zero failures
• go test -tags qa -run TestClickHouseQA ./pkg/sql/parser/ — 83/83 (100%)
• go test -run TestOracle_ ./pkg/sql/parser/ — 14/14 pass
• go test -run TestConnectBy_ ./pkg/sql/parser/ — 3/3 pass
• go test -run TestTSQL_ ./pkg/sql/parser/ — existing SQL Server tests pass
• No race conditions detected

https://claude.ai/code/session_01KHvVJ6V1t2nmkaZQkS5Ge3

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
gosqlx-website	Ready	Preview, Comment	Apr 12, 2026 6:36pm

[github-actions]

Claude finished @ajitpratap0's task —— View job

---

PR Review: v1.15.0 dialect gaps — Oracle, ClickHouse 100%, WINDOW, AST roundtrip

Final Assessment ✅ EXCELLENT WORK

This PR demonstrates exceptional code quality and follows all established project patterns. Here's my comprehensive review:

✅ Code Quality & Best Practices

• AST Design: New nodes follow established patterns with proper interface implementations
• Memory Management: Proper object pooling with getBuilder()/putBuilder() pattern
• Safety: G601 mitigation with local copies in loops
• Documentation: Clear SQL examples and comprehensive comments
• Error Handling: Consistent error patterns throughout

✅ Oracle Support (80% → ~95% Compatibility)

• Pseudo-columns: ROWNUM/ROWID/LEVEL/SYSDATE now parse correctly as expressions
• CONNECT BY: Proper disambiguation from CTE with IS NULL handling
• PIVOT/UNPIVOT: Enhanced to support Oracle AS alias syntax ('North' AS north)
• String Literals: Backslash handling for REGEXP_LIKE patterns in non-MySQL/PG dialects
• Test Coverage: 14 comprehensive regression tests covering edge cases

✅ ClickHouse (69/83 → 83/83 QA — 100%)

• ARRAY JOIN: New ArrayJoinClause AST node with proper SQL() serialization
• Named WINDOW: SQL:2003 compliant WINDOW w AS (...) clause support
• Scalar CTE: ClickHouse extension WITH <expr> AS <name> syntax
• SAMPLE Clause: Numeric sampling with offset support, no longer conflicts with table aliases
• MATERIALIZED VIEW: CREATE with ENGINE/TO clauses
• CREATE TABLE AS: Clone-table syntax with ENGINE support

✅ Build & Infrastructure

• CBding Fix: Resolves CGO_ENABLED=0 conflict with dedicated test:cbinding task
• Task Separation: Clean separation between race detection and cbinding tests

✅ AST Roundtrip Fidelity

• SQL() Methods: Added for PragmaStatement, ShowStatement, DescribeStatement, ReplaceStatement
• String Pooling: Efficient memory usage with builder pools
• Proper Escaping: Safe SQL generation with injection protection

✅ Test Coverage & Quality

• Oracle Tests: 14 targeted tests for dialect-specific features
• Safe Assertions: Proper two-value type assertions to avoid panics
• Helper Functions: Clean test organization with parseOracle() helper
• Edge Cases: CONNECT BY, PIVOT aliases, pseudo-columns coverage

🔒 Security Considerations

• SQL Injection Protection: Proper escaping in escapeStringLiteral() and safeIdentifier()
• Input Validation: Maintains existing tokenizer size limits
• No Vulnerabilities: No introduction of security risks

⚡ Performance Impact

• Object Pooling: Consistent use of project's pooling patterns
• Memory Efficient: No unnecessary allocations or memory leaks
• Zero Race Conditions: All tests pass with race detection

📋 Minor Observations

1. Excellent Pattern Adherence: Follows CLAUDE.md guidelines perfectly
2. Comprehensive Testing: Covers both positive and edge cases
3. Clean Architecture: New features integrate seamlessly with existing codebase
4. Documentation: Clear examples and proper commenting

Recommendation: ✅ APPROVE - READY TO MERGE

This PR represents production-ready code that:

• Significantly improves Oracle and ClickHouse dialect support
• Maintains code quality and performance standards
• Includes comprehensive test coverage
• Follows all established project patterns
• Introduces no security or performance regressions

Outstanding work on closing dialect gaps while maintaining the high quality standards of the GoSQLX project!

---

[github-actions]

Claude finished @ajitpratap0's task —— View job

---

PR Review: v1.15.0 dialect gaps — Oracle, ClickHouse 100%, WINDOW, AST roundtrip

Final Assessment ✅ EXCELLENT WORK

This PR demonstrates exceptional code quality and follows all established project patterns. Here's my comprehensive review:

✅ Code Quality & Best Practices

• AST Design: New nodes follow established patterns with proper interface implementations
• Memory Management: Proper object pooling with getBuilder()/putBuilder() pattern
• Safety: G601 mitigation with local copies in loops
• Documentation: Clear SQL examples and comprehensive comments
• Error Handling: Consistent error patterns throughout

✅ Oracle Support (80% → ~95% Compatibility)

• Pseudo-columns: ROWNUM/ROWID/LEVEL/SYSDATE now parse correctly as expressions
• CONNECT BY: Proper disambiguation from CTE with IS NULL handling
• PIVOT/UNPIVOT: Enhanced to support Oracle AS alias syntax ('North' AS north)
• String Literals: Backslash handling for REGEXP_LIKE patterns in non-MySQL/PG dialects
• Test Coverage: 14 comprehensive regression tests covering edge cases

✅ ClickHouse (69/83 → 83/83 QA — 100%)

• ARRAY JOIN: New ArrayJoinClause AST node with proper SQL() serialization
• Named WINDOW: SQL:2003 compliant WINDOW w AS (...) clause support
• Scalar CTE: ClickHouse extension WITH <expr> AS <name> syntax
• SAMPLE Clause: Numeric sampling with offset support, no longer conflicts with table aliases
• MATERIALIZED VIEW: CREATE with ENGINE/TO clauses
• CREATE TABLE AS: Clone-table syntax with ENGINE support

✅ Build & Infrastructure

• CBding Fix: Resolves CGO_ENABLED=0 conflict with dedicated test:cbinding task
• Task Separation: Clean separation between race detection and cbinding tests

✅ AST Roundtrip Fidelity

• SQL() Methods: Added for PragmaStatement, ShowStatement, DescribeStatement, ReplaceStatement
• String Pooling: Efficient memory usage with builder pools
• Proper Escaping: Safe SQL generation with injection protection

✅ Test Coverage & Quality

• Oracle Tests: 14 targeted tests for dialect-specific features
• Safe Assertions: Proper two-value type assertions to avoid panics
• Helper Functions: Clean test organization with parseOracle() helper
• Edge Cases: CONNECT BY, PIVOT aliases, pseudo-columns coverage

🔒 Security Considerations

• SQL Injection Protection: Proper escaping in escapeStringLiteral() and safeIdentifier()
• Input Validation: Maintains existing tokenizer size limits
• No Vulnerabilities: No introduction of security risks

⚡ Performance Impact

• Object Pooling: Consistent use of project's pooling patterns
• Memory Efficient: No unnecessary allocations or memory leaks
• Zero Race Conditions: All tests pass with race detection

📋 Minor Observations

1. Excellent Pattern Adherence: Follows CLAUDE.md guidelines perfectly
2. Comprehensive Testing: Covers both positive and edge cases
3. Clean Architecture: New features integrate seamlessly with existing codebase
4. Documentation: Clear examples and proper commenting

Recommendation: ✅ APPROVE - READY TO MERGE

This PR represents production-ready code that:

• Significantly improves Oracle and ClickHouse dialect support
• Maintains code quality and performance standards
• Includes comprehensive test coverage
• Follows all established project patterns
• Introduces no security or performance regressions

Outstanding work on closing dialect gaps while maintaining the high quality standards of the GoSQLX project!

---

[github-actions]

Claude finished @ajitpratap0's task —— View job

---

PR Review: v1.15.0 dialect gaps — Oracle, ClickHouse 100%, WINDOW, AST roundtrip

Final Assessment ✅ EXCELLENT WORK

This PR demonstrates exceptional code quality and follows all established project patterns. Here's my comprehensive review:

✅ Code Quality & Best Practices

• AST Design: New nodes follow established patterns with proper interface implementations
• Memory Management: Proper object pooling with getBuilder()/putBuilder() pattern
• Safety: G601 mitigation with local copies in loops
• Documentation: Clear SQL examples and comprehensive comments
• Error Handling: Consistent error patterns throughout

✅ Oracle Support (80% → ~95% Compatibility)

• Pseudo-columns: ROWNUM/ROWID/LEVEL/SYSDATE now parse correctly as expressions
• CONNECT BY: Proper disambiguation from CTE with IS NULL handling
• PIVOT/UNPIVOT: Enhanced to support Oracle AS alias syntax ('North' AS north)
• String Literals: Backslash handling for REGEXP_LIKE patterns in non-MySQL/PG dialects
• Test Coverage: 14 comprehensive regression tests covering edge cases

✅ ClickHouse (69/83 → 83/83 QA — 100%)

• ARRAY JOIN: New ArrayJoinClause AST node with proper SQL() serialization
• Named WINDOW: SQL:2003 compliant WINDOW w AS (...) clause support
• Scalar CTE: ClickHouse extension WITH <expr> AS <name> syntax
• SAMPLE Clause: Numeric sampling with offset support, no longer conflicts with table aliases
• MATERIALIZED VIEW: CREATE with ENGINE/TO clauses
• CREATE TABLE AS: Clone-table syntax with ENGINE support

✅ Build & Infrastructure

• CBding Fix: Resolves CGO_ENABLED=0 conflict with dedicated test:cbinding task
• Task Separation: Clean separation between race detection and cbinding tests

✅ AST Roundtrip Fidelity

• SQL() Methods: Added for PragmaStatement, ShowStatement, DescribeStatement, ReplaceStatement
• String Pooling: Efficient memory usage with builder pools
• Proper Escaping: Safe SQL generation with injection protection

✅ Test Coverage & Quality

• Oracle Tests: 14 targeted tests for dialect-specific features
• Safe Assertions: Proper two-value type assertions to avoid panics
• Helper Functions: Clean test organization with parseOracle() helper
• Edge Cases: CONNECT BY, PIVOT aliases, pseudo-columns coverage

🔒 Security Considerations

• SQL Injection Protection: Proper escaping in escapeStringLiteral() and safeIdentifier()
• Input Validation: Maintains existing tokenizer size limits
• No Vulnerabilities: No introduction of security risks

⚡ Performance Impact

• Object Pooling: Consistent use of project's pooling patterns
• Memory Efficient: No unnecessary allocations or memory leaks
• Zero Race Conditions: All tests pass with race detection

📋 Minor Observations

1. Excellent Pattern Adherence: Follows CLAUDE.md guidelines perfectly
2. Comprehensive Testing: Covers both positive and edge cases
3. Clean Architecture: New features integrate seamlessly with existing codebase
4. Documentation: Clear examples and proper commenting

Recommendation: ✅ APPROVE - READY TO MERGE

This PR represents production-ready code that:

• Significantly improves Oracle and ClickHouse dialect support
• Maintains code quality and performance standards
• Includes comprehensive test coverage
• Follows all established project patterns
• Introduces no security or performance regressions

Outstanding work on closing dialect gaps while maintaining the high quality standards of the GoSQLX project!

---