fix(metadata): drop unneeded scrollbar on MetadataText values#765
Merged
Conversation
Each MetadataText value rendered with `overflow-y: scroll`, which forces a scrollbar even when no max-height is set. Chromium-based Edge on Windows draws classic scrollbar arrow buttons on every forced scrollbar, producing visible up/down chevrons next to single-line values like the publisher, bookmark progress, and date. Other Chromium browsers don't draw the arrows, so this only manifested on Edge. Switch to `overflow-y: auto` so the scrollbar only appears for the two fields that actually need it (Summary and Review, which have `max-height: 100`). The `isOverflow` measurement still works since it compares `clientHeight` to `scrollHeight`, which is identical under `auto`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Edge for Windows the metadata dialog renders tiny up/down chevron
controls next to nearly every text field (publisher, bookmark progress,
date, tagger, etc.). The chevrons are Edge's classic Windows scrollbar
arrow buttons — every
MetadataTextvalue div hadoverflow-y: scroll,which forces a scrollbar to render permanently, and Chromium-based Edge
draws arrow buttons on forced scrollbars where other Chromium browsers
don't. Hence Edge-only.
The scroll was only ever needed for the two fields that get
:max-height="100"(Summary and Review inmetadata-body.vue); oneverything else the forced scrollbar was decorative noise.
Switch to
overflow-y: autoso the scrollbar only appears when contentactually overflows. The
isOverflowmeasurement inmounted()keepsworking —
clientHeight < scrollHeightis unaffected byscrollvsauto.Test plan
up/down chevrons next to publisher, bookmark progress, date,
tagger, and other single-line values are gone.
before (no visible regression).
capped at 100px, still scrollable, and the "Show more" expand
button still appears.
🤖 Generated with Claude Code