feat(reader): swipe to turn pages on touch devices#766
Merged
Conversation
Override v-window's default touch handlers in the horizontal pager so left/right swipes route through ``routeToDirection`` instead of trying to flip between the (disabled) v-window items. Mirrors the keyboard arrow behavior, so RTL handling is automatic via ``normalizeDirection``. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v-window's built-intouchprop with handlers that callrouteToDirection. Vuetify's touch directive already lives on that element — the defaults try to flip between v-window items, which aredisabledhere and rely on URL routing instead.routeToDirectionnormalizes the direction throughnormalizeDirection, so manga / right-to-left books swap left/right just like the arrow keys do.Notes for reviewer
developbefore this change: the v1.12.3 version bump + news, and a merge fromdevelop. Those commits are unrelated to the swipe feature and just rode along on this branch.Test plan
🤖 Generated with Claude Code