✨ Quality: Browser integration tests do not cover ajv2020 and ajvJTD UMD bundles#2600
Open
Hikkywannafly wants to merge 1 commit into
Conversation
…d` umd bundles The browser test runner only loads `bundle/ajv7.min.js` and `bundle/ajv2019.min.js`, while the build config also produces `ajv2020` and `ajvJTD` bundles. This leaves two published browser artifacts unverified in CI, so bundling/runtime regressions in those entrypoints can ship undetected. Affected files: karma.conf.js Signed-off-by: - nyankoiscat - <76279331+Hikkywannafly@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Code Quality
Problem
The browser test runner only loads
bundle/ajv7.min.jsandbundle/ajv2019.min.js, while the build config also producesajv2020andajvJTDbundles. This leaves two published browser artifacts unverified in CI, so bundling/runtime regressions in those entrypoints can ship undetected.Severity:
highFile:
karma.conf.jsSolution
Extend Karma inputs and add browser specs for each missing bundle. For example: 1) In
karma.conf.jsadd:"bundle/ajv2020.min.js""bundle/ajvJTD.min.js".browser/ajv2020.spec.js:new ajv2020.default()(or exposed global).browser/jtd.spec.js:Changes
karma.conf.js(modified)What issue does this pull request resolve?
What changes did you make?
Is there anything that requires more attention while reviewing?
🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #2599