Fixes a number of memory issues reported by AddressSanitizer.#26
Open
gmbeard wants to merge 1 commit into
Open
Fixes a number of memory issues reported by AddressSanitizer.#26gmbeard wants to merge 1 commit into
gmbeard wants to merge 1 commit into
Conversation
*ASan* detects lots of leaks relating to the *context stack*. Fixed by adding `free(context)` to `POP_CONTEXT`, and clearing any remaining items on the stack after parsing has completed. The `examples/example.toml` file fails *ASan*, asserting on invalid memory access. Fixed by ensuring that a list node's name is set to `NULL` if no name was parsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of memory issues reported by AddressSanitizer.
Memory Leaks
ASan detects lots of leaks. They all look similar to the below...
The fixes for these are...
free(context)to thePOP_CONTEXT(x)macro. (toml_parse.rl)%%write_execsection, loop over the remaining items in the context stack, callingPOP_CONTEXT(...)on each. (toml_parse.rl)Invalid Memory Access
The
examples/example.tomlfile fails ASan, giving the following error...It appears to be a problem with lists. Ensuring that, if there is no
namepresent, settingitem->node.name = NULLin thestart_listaction appears to fix this. (toml_parse.rl)NOTE: I've only tested these fixes with the provided example
.tomlfiles in the project. However, it looks as though these fixes may go some way to addressing issues #18,#19, #20, #22, #23, and #24.