Skip to content

Commit ea59f08

Browse files
committed
fix(x/bme): use transient store for ledger sequence
remove sequence resent on BeginBlocker Signed-off-by: Artur Troian <troian@users.noreply.github.com>
1 parent a328ef3 commit ea59f08

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

x/bme/keeper/abci.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,13 @@ import (
1717

1818
// BeginBlocker is called at the beginning of each block
1919
func (k *keeper) BeginBlocker(ctx context.Context) error {
20+
sctx := sdk.UnwrapSDKContext(ctx)
2021
// reset the ledger sequence on each new block
2122
// sequence must start from 1 for ledger record id range to work correctly
22-
_ = k.ledgerSequence.Set(ctx, 0)
23+
err := k.ledgerSequence.Set(ctx, 0)
24+
if err != nil {
25+
sctx.Logger().Error("failed to reset ledger sequence", "err", err)
26+
}
2327

2428
return nil
2529
}

x/bme/keeper/keeper.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ func NewKeeper(
129129
ledgerCanceled: collections.NewMap(sb, LedgerFailedKey, "ledger_canceled", ledgerRecordIDCodec{}, codec.CollValue[bmetypes.LedgerCanceledRecord](cdc)),
130130
ledgerPendingBalances: collections.NewMap(sb, LedgerPendingBalancesKey, "ledger_pending_balances", collections.StringKey, sdk.IntValue),
131131
ledger: collections.NewMap(sb, LedgerKey, "ledger", ledgerRecordIDCodec{}, codec.CollValue[bmetypes.LedgerRecord](cdc)),
132-
ledgerSequence: collections.NewItem(sb, LedgerSequenceKey, "ledger_sequence", collections.Int64Value),
132+
ledgerSequence: collections.NewItem(tsb, LedgerSequenceKey, "ledger_sequence", collections.Int64Value),
133133
}
134134

135135
schema, err := sb.Build()
@@ -842,6 +842,8 @@ func (k *keeper) RequestBurnMint(ctx context.Context, srcAddr sdk.AccAddress, ds
842842
return id, nil
843843
}
844844

845+
// nextLedgerSeq returns the next ledger sequence number and increments it
846+
// on each block sequence starts from 1
845847
func (k *keeper) nextLedgerSeq(ctx sdk.Context) (int64, error) {
846848
seq, err := k.ledgerSequence.Get(ctx)
847849
if err != nil {

0 commit comments

Comments
 (0)