Skip to content

Support engine.worker.capacity.unbounded configuration #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfallows merged 2 commits into from
Jun 15, 2025
Merged

Support engine.worker.capacity.unbounded configuration #1500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ef42b0
Rename engine.worker metrics to engine.workers metrics
jfallows Jun 14, 2025
d4646bc
Support zilla.engine.worker.capacity.unbounded config, defaults to false
jfallows Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...-tcp/src/main/java/io/aklivity/zilla/runtime/binding/tcp/internal/TcpCapacityTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
package io.aklivity.zilla.runtime.binding.tcp.internal;

import static io.aklivity.zilla.runtime.engine.EngineConfiguration.ENGINE_WORKER_CAPACITY;
import static io.aklivity.zilla.runtime.engine.EngineConfiguration.ENGINE_WORKER_CAPACITY_LIMIT;

import java.util.function.LongConsumer;

Expand All @@ -32,7 +32,7 @@ public TcpCapacityTracker(
TcpConfiguration config,
EngineContext context)
{
this.capacity = ENGINE_WORKER_CAPACITY.getAsInt(config);
this.capacity = ENGINE_WORKER_CAPACITY_LIMIT.getAsInt(config);
this.recordUsage = context.supplyUtilizationMetric();
}

Expand Down
12 changes: 12 additions & 0 deletions runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/EngineConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ public class EngineConfiguration extends Configuration
public static final PropertyDef<Path> ENGINE_CACHE_DIRECTORY;
public static final PropertyDef<HostResolver> ENGINE_HOST_RESOLVER;
public static final IntPropertyDef ENGINE_WORKER_CAPACITY;
public static final IntPropertyDef ENGINE_WORKER_CAPACITY_LIMIT;
public static final BooleanPropertyDef ENGINE_WORKER_CAPACITY_UNBOUNDED;
public static final DoublePropertyDef ENGINE_MEMORY_PERCENTAGE;
public static final DoublePropertyDef ENGINE_DISK_PERCENTAGE;
public static final IntPropertyDef ENGINE_BUFFER_POOL_CAPACITY;
Expand Down Expand Up @@ -111,6 +113,8 @@ public class EngineConfiguration extends Configuration
ENGINE_MEMORY_PERCENTAGE = config.property("memory.percentage", 0.25);
ENGINE_DISK_PERCENTAGE = config.property("disk.percentage", 0.75);
ENGINE_WORKER_CAPACITY = config.property("worker.capacity", EngineConfiguration::defaultWorkerCapacity);
ENGINE_WORKER_CAPACITY_UNBOUNDED = config.property("worker.capacity.unbounded", false);
ENGINE_WORKER_CAPACITY_LIMIT = config.property("worker.capacity.limit", EngineConfiguration::defaultWorkerCapacityLimit);
ENGINE_BUFFER_POOL_CAPACITY = config.property("buffer.pool.capacity", EngineConfiguration::defaultBufferPoolCapacity);
ENGINE_BUFFER_SLOT_CAPACITY = config.property("buffer.slot.capacity", 32 * 1024);
ENGINE_STREAMS_BUFFER_CAPACITY = config.property("streams.buffer.capacity",
Expand Down Expand Up @@ -426,6 +430,14 @@ private static int defaultWorkerCapacity(
return newWorkersCapacity;
}

private static int defaultWorkerCapacityLimit(
Configuration config)
{
return ENGINE_WORKER_CAPACITY_UNBOUNDED.get(config)
? Integer.MAX_VALUE
: ENGINE_WORKER_CAPACITY.get(config);
}

private static URL configURL(
Configuration config,
String url)
Expand Down
4 changes: 2 additions & 2 deletions ...engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/EngineWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
package io.aklivity.zilla.runtime.engine.internal.registry;

import static io.aklivity.zilla.runtime.engine.EngineConfiguration.ENGINE_WORKER_CAPACITY;
import static io.aklivity.zilla.runtime.engine.EngineConfiguration.ENGINE_WORKER_CAPACITY_LIMIT;
import static io.aklivity.zilla.runtime.engine.budget.BudgetCreditor.NO_BUDGET_ID;
import static io.aklivity.zilla.runtime.engine.concurrent.Signaler.NO_CANCEL_ID;
import static io.aklivity.zilla.runtime.engine.internal.registry.MetricHandlerKind.ORIGIN;
Expand Down Expand Up @@ -895,7 +895,7 @@ public void onStart()
LongConsumer recordUtilization = supplyGaugeWriter(utilizationMetricId);

recordCount.accept(1);
recordCapacity.accept(ENGINE_WORKER_CAPACITY.getAsInt(config));
recordCapacity.accept(ENGINE_WORKER_CAPACITY_LIMIT.getAsInt(config));
recordUtilization.accept(0);
}
}
Expand Down
Loading