Fixes for sb_rand and sb_memory and supported parameters extension for memory test#455
Open
evvoevod wants to merge 4 commits intoakopytov:masterfrom
Open
Fixes for sb_rand and sb_memory and supported parameters extension for memory test#455evvoevod wants to merge 4 commits intoakopytov:masterfrom
evvoevod wants to merge 4 commits intoakopytov:masterfrom
Conversation
added 4 commits
May 17, 2022 15:46
…' distribution has been dropped Zero initialized rand_iter variable led to zero offset returnd by sb_rand_gaussian function resulting in broken gaussian distribution accessing only index 0 in the workset array
Author
|
@akopytov ping... |
|
I faced the broken |
Author
|
@akopytov, could you please review these patches? Random memory access patterns are broken. |
1 similar comment
Author
|
@akopytov, could you please review these patches? Random memory access patterns are broken. |
Author
|
@akopytov, I'd really appreciate your feedback on these fixes. Currently, gaussian random generator is broken and returns zero offsets always which results in corrupted memory access throughput in benchmarks. |
Author
dveeden
approved these changes
Mar 14, 2025
Contributor
dveeden
left a comment
dveeden
left a comment
There was a problem hiding this comment.
This all looks ok to me, but I don't use/know this part of sysbench very well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit fixes critical bug in sb_rand which broke Gaussian distribution due to 'rand_iter' initialized to zero after Special distribution has got dropped.
Second commit extends supported --memory-total-size and --memory-block-size parameters values allowing total size to be smaller than block size. This allows another level of control of benchmarking to the user.
Third commit provides support of periodic statistics in memory tests which is not supported currently. It allows to periodically report throughput during memory test run. On the other hand it decreases benchmark throughput roughly by 5% depending on access type and distribution used and underlying hardware.
Fourth commit extends sb_rand to use 64-bits variables and functions parameters which allows to use --memory-block-size values larger than 16GB.